🇨🇦Canada @dstorozhuk

dhruv.mittal please test the code you propose by pulling your branch to another Drupal installation. There are still in proposed PR.

dhruv.mittal I don't see the how the code in https://git.drupalcode.org/project/redirects_fixer/-/merge_requests/5 relates to this issue.

Did you miss to commit some files?
Please don't change the titles of the fields.

You can add the typo fix in this PR.

Please test the module after your fixes and provide a feedback after testing. Thanks.

dhruv.mittal could you please create a merge request?

jasonglisson can I also get some credits? I was volunteering also on DrupalGov 2024. Thanks.

So we just need to add ourself here?

dstorozhuk → created an issue.

Please create a MR. No need to create a patches

What was the problem with configuration link?

Hetal.Solanki Please recreate the PR, since it cannon be merged.

Hetal.Solanki , sarwan_verma, Sourav_Paul if you propose some changes in a code - please test the code manually before creating MR.
Fixing the code with automated tool have zero sense if module become broken after that.
Thanks.

dstorozhuk → created an issue.

This one os merged.

Merged.

Merged. If that the only change we need to be compatible with D11 - then great 😊.

Looks good to me.

Guys, I see did some efforts fixing the code styles, thanks. The last update of this issue was 20 day ago.
However, GITLab CI was introduced on 13 July 2023 https://www.drupal.org/association/blog/gitlab-ci-is-now-enabled-for-eve... → .
So the right direction of this issue should be add the integration for the GITLab CI and then fix the remaining code styles issue.
But, since we already did that in another issue - this issue does not make sense any more and could be closed.

Code looks good to me. Thanks. Will Merge.

dstorozhuk → created an issue.

There couple if fixes left with PHP and Spell check.

completed in 📌 Drupal 10 compatibility Fixed

completed in #3434777

Completed

dstorozhuk → created an issue.

dstorozhuk → made their first commit to this issue’s fork.

dstorozhuk → created an issue.

dstorozhuk → created an issue.

@Kostiantyn we can close that task and merge. I will open a separate issue for Search By State.

Since this a Drupal core issue - closing in favour for related task. See https://www.drupal.org/project/drupal/issues/3122011#comment-13950695 🐛 Grouping support for Item and Email FormElements Needs work as proposed by other members.

@Viktor Holovachek looks test are failing on a GitLab CI pipeline. In DrupalCI test was green.

Ah, I am so sorry. I miss understood you. I thought by saying "fixed" and "issue" you particularly meant changed the status of current issue ticket 3432888 to "fixed" without doing any action.
Now I understand your reaction. Sorry for my misunderstanding, I needed to check the module homepage first.
Sorry again for misunderstanding and have a nice day.

I want to consolidate the efforts and keep only a single solution. I provided the argumentation why should we keep the single solution and why it should be views_url_alias.

If you don’t want to consolidate the efforts - please provide your argumentation.
Probably we should abandon views_url_alias module and keep your solution if it is better.

One of key rule of contribution to Drupal codebase is to develop and improve existing solution rather then creating similar another solution. That is power of Drupal community in comparison to Wordpress community for example.

Thank.

Hey, it is not good silently close the ticket.
Please answer and provide the reason why you don’t want to respond to the request. Otherwise I will write to admins explaining them the situation.

I don't think this issue is valid any more in 3.x.
Can anyone test it again?

dstorozhuk → created an issue.

dstorozhuk → created an issue.

Queue options might not work for people who has cron disabled for some reason.
I think the right option here is Batch operation for views_url_alias_rebuild_path(). But also module installation should use batch somehow.

This issue still valid in term of adding the language filter.
I fixed in 3.x-dev the issue with saving the language dependent data to views_url_alias, but the filter or view query still need to added to make sure we can filter by specific/current language.

Fixed in some of the 8.x-2.x issues. https://www.drupal.org/project/views_url_alias/issues/3432285 🐛 views_url_alias not updated when Patchauto updates alias for Taxonomy Term Fixed
Issue with a huge amount of url aliases will be addressed in separate task.

Patch from this issue does not provide the hook_update_N implementation.
Fixed in dev branch.

Fixed in dev branch, will be released once tested.

Fixed in dev branch, will be released once tested.

Since we can't create releases after older then 3.x because we already have a 2.x release - I was we should start from 3.x branch.

dstorozhuk → created an issue.

Ok.

>3.0.0 everything works as expected.
Because in 3.0.0 on Drupal version 8.8 and above the hooks which suppose to update/insert/delete records in views_url_alias table was never triggered.
That it why you had an impression that everything was working fine. Your site, if it is on Drupal version 8.8 and above, might use outdated data that was installed on the first time of the module installation.
Please check that.
Which Drupal version are you using?

Amazing!
Thanks.

dstorozhuk → created an issue.

After apply the patch from merge request !5978 I have that error.
The service "content_moderation.workspace_subscriber" has a dependency on a non-existent service "workspaces.association".

The website encountered an unexpected error. Try again later.

TypeError: views_url_alias_path_alias_update(): Argument #1 ($path_alias) must be of type PathAliasInterface, Drupal\path_alias\Entity\PathAlias given in views_url_alias_path_alias_update() (line 56 of modules/contrib/views_url_alias/views_url_alias.module).
call_user_func_array(Object, Array) (Line: 409)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'views_url_alias') (Line: 388)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('path_alias_update', Object) (Line: 408)
Drupal\Core\Extension\ModuleHandler->invokeAll('path_alias_update', Array) (Line: 215)
Drupal\Core\Entity\EntityStorageBase->invokeHook('update', Object) (Line: 900)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object) (Line: 564)
Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, 1) (Line: 781)
Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, 1) (Line: 489)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 806)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 354)
Drupal\Core\Entity\EntityBase->save() (Line: 126)
Drupal\pathauto\AliasStorageHelper->save(Array, Object, 'update') (Line: 273)
Drupal\pathauto\PathautoGenerator->createEntityAlias(Object, 'update') (Line: 381)
Drupal\pathauto\PathautoGenerator->updateEntityAlias(Object, 'update') (Line: 93)
pathauto_entity_update(Object)
call_user_func_array(Object, Array) (Line: 409)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'pathauto') (Line: 388)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('entity_update', Object) (Line: 408)
Drupal\Core\Extension\ModuleHandler->invokeAll('entity_update', Array) (Line: 217)
Drupal\Core\Entity\EntityStorageBase->invokeHook('update', Object) (Line: 900)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('update', Object) (Line: 564)
Drupal\Core\Entity\EntityStorageBase->doPostSave(Object, 1) (Line: 781)
Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object, 1) (Line: 489)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 806)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 354)
Drupal\Core\Entity\EntityBase->save() (Line: 270)
Drupal\node\NodeForm->save(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('node_blog_post_edit_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 178)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Nice catch , _shK.
You and Andrii Kondratenko introduced the error in dev branch.
https://git.drupalcode.org/project/views_url_alias/-/commit/da56446c1f02...
Please fix the error since dev release throwing the php error now.

I think this issue still valid. Patch from neptune-dc Looks pretty big. Can you, neptune-dc, please create a pull request and remove all non task related issue from you proposal? Or better to cooperate with NicholasS and add changes to his MR.

dstorozhuk → created an issue.

Do we need that task taking into account that branch 8.x-1.x-dev is for Drupal before 8.8, and and this version of the Drupal is not maintained any more.
I propose to close the Issue, and ones that need that fix for their old Drupal 8 sites - can apply patch.

BTW, _shY, I don't see the mentioned coding standard issues in a pipeline, and it should not be there. How are you running the phpcs ? Does it have access to Drupal Core 8.8 above?

Thanks for suggestions, about .cspell-project-words.txt _shY. We will fix that.

Hey folks, please resolve conflict in MR.

dstorozhuk → created an issue.

dstorozhuk → created an issue.

dstorozhuk → created an issue.

Here is the patch for which will make that module works with Drupal 9 and 10.
Version 3.0.0 is not compatible with Drupal 9/10 because - see my previous comment.
Not sure what to do with versioning, probably need to abalone the branch 3.x and unpublish the release.
Or add additional patch to keep the old hooks _path_[action] + new patch_alias entity hooks.
And then create a new 4.x branch that only compatible with Drupal 9 and 10.

At least, latest (3.x) version of the module is not compatible with Drupal 9/10 https://api.drupal.org/api/drupal/core%21modules%21path%21path.api.php/f....

Module use hook_path_update but in starting from 9.0.0 module has to use hook_path_alias_update().

I will try to create a patch, and do more discovery later.

dstorozhuk → created an issue.

dstorozhuk → created an issue.

AstonVictor please resolve the conflicts.

Merged that one.

Sorry, wrong issue. Wanted to post in #3371709

I think module should not load code mirror plugin is source code plugin is not enabled for particular Text format configuration.

I think module should not load code mirror plugin is source code plugin is not enabled for particular Text format configuration.

Improve description