- Issue created by @arthur.baghdasar
- Merge request !59Issue #3516580 by arthur.baghdasar: ImageFieldFormatter fails with Stage File... → (Open) created by arthur.baghdasar
When using the ImageFieldFormatter plugin from the Entity Embed module in a development environment that uses the
Stage File Proxy →
module, image embeds fail with an error message like:
The selected image "@image" is invalid.
This occurs because ImageFieldFormatter::isValidImage() calls $this->imageFactory->get($uri)->isValid()
on the image file, but if the file doesn't exist locally yet, the validation fails.
Stage File Proxy downloads images lazily only when accessed via an HTTP request, but the image validation does not trigger this fetch.
public://.Expected result:
Image is fetched and embedded normally.
Actual result:
An error message is shown: "The selected image is invalid."
Additionally, a PHP warning may be logged about the file not being found.
Update the ImageFieldFormatter::isValidImage() method to check if the file exists locally, and if not, trigger an HTTP request
to the file’s public URL using Drupal’s HTTP client (\Drupal::httpClient()). This ensures Stage File Proxy downloads the file before validation occurs.
if (!file_exists($local_path)) { try { $url = \Drupal::service('stream_wrapper_manager')->getViaUri($uri)->getExternalUrl(); \Drupal::httpClient()->get($url); } catch (\Exception $e) { $this->messenger->addError($this->t('The image "@image" could not be downloaded via Stage File Proxy.', ['@image' => $entity->label()])); return AccessResult::forbidden(); } }
Active
1.0
Code