- πΊπΈUnited States smustgrave
Was previously tagged for tests in #6 which still needs to happen please.
- π§πͺBelgium Mav_fly
I also can confirm that the patch provided in #5 fixes the bug.
My setup:
Drupal 10.2.4
Field Group 8.x-3.4
Account field split 2.0.2 - Merge request !7131Fix grouping support for all core FormElement plugins. β (Open) created by Ruuds
- Status changed to Needs review
about 1 year ago 2:53pm 21 March 2024 - π³π±Netherlands Ruuds
So as the issue only seems to occur when grouping elements using the field_group module, do we really want to rebuild the logic that field_group uses for grouping elements into a core test? Creating a dependency to the field_group module for a specific core test doe also not feel right.
I've created a MR which contains a test which checks if all FormElement plugins defined by core have a #process callback to processGroup, which solves the problem. Running that test, I discovered additional FormElements which also did not have the #process callback.
Probably work in this MR will be removed again when https://www.drupal.org/project/drupal/issues/2190333 π Make #group FAPI / render feature work on all form/render #types out of the box Needs work gets fixed.
- Status changed to Needs work
about 1 year ago 2:50pm 24 March 2024 - πΊπΈUnited States smustgrave
Issue summary needs to be updated. I added the template but left the sections empty. Main ones needed are steps to reproduce and proposed solution. If no UI or date model change NA is fine.
After that probably can ask sub-maintainer for review of solution.
- Status changed to Needs review
about 1 year ago 11:55am 26 March 2024 - Status changed to Needs work
about 1 year ago 3:52am 3 April 2024 The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 7:48am 3 April 2024 - π³π±Netherlands Ruuds
I don't think anything needs to be changed? The mentioned class (Drupal\Core\Render\Element\FormElementBase) by the needs-review-queue-bot does not exist and FormElement is not marked as deprecated?
- Status changed to Needs work
about 1 year ago 8:28am 3 April 2024 The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- First commit to issue fork.
- πͺπΈSpain vidorado LogroΓ±o (La Rioja)
Rebased onto latest 11.x branch.
Multiple tests are failing now, but I haven't managed to fix them.
RenderElementBase::preRenderGroup
andRenderElementBase::preRenderGroup
seem to do something that makes some elements don't appear on the page on functional tests.