- Issue created by @radheymkumar
- 🇨🇦Canada dstorozhuk Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
What was the problem with configuration link?
- 🇨🇦Canada dstorozhuk Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
Please create a MR. No need to create a patches
- Assigned to dhruv.mittal
- 🇨🇦Canada dstorozhuk Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
dhruv.mittal could you please create a merge request?
- Merge request !4Issue-redirects_fixer-3465490/3465490-update-config-form:Updated config Form → (Open) created by dhruv.mittal
dhruv.mittal → changed the visibility of the branch 3465490-update-config-form to hidden.
- Merge request !5Issue-redirects_fixer-3465490/3465490-update-setting-form:Updated setting form → (Open) created by dhruv.mittal
Hey dstorozhuk !!
I have raised MR Please review And I found a typo in setting form at line no. 65 there is Site domain filed instead of Site domain field. Can I create a separate issue to fix that.??- 🇨🇦Canada dstorozhuk Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
dhruv.mittal I don't see the how the code in https://git.drupalcode.org/project/redirects_fixer/-/merge_requests/5 relates to this issue.
Did you miss to commit some files?
Please don't change the titles of the fields.You can add the typo fix in this PR.
Please test the module after your fixes and provide a feedback after testing. Thanks.
Hey dstorozhuk!!
I have committed all the files,reverted changes made in title and also fixed the typo.
no longer have repeated calls to $this->config('redirects_fixer.settings') by doing this we can avoid making multiple calls to the configuration service, which is a good practice for performance and readability, and the issue also states it- 🇨🇦Canada dstorozhuk Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
dhruv.mittal please test the code you propose by pulling your branch to another Drupal installation. There are still in proposed PR.