🇺🇸United States @sethhill

This change looks good. Will merge shortly.

sethhill → made their first commit to this issue’s fork.

MR adds a check for creation permission of a certain paragraph type in order to control visibility of the duplication controls.

sethhill → made their first commit to this issue’s fork.

sethhill → created an issue.

This ended up fitting in with tests that I was writing for https://www.drupal.org/project/layout_paragraphs/issues/3440313 ✨ Allow View Mode Selection Inside Layout Paragraphs Widget Fixed , and I added this functionality into MR!167 on that ticket.

Rerolled the patch in #61 against 10.3.x

This appears to be a duplicate of https://www.drupal.org/project/layout_paragraphs/issues/3265794 🐛 Modal form actions broken if subform has validation errors or certain AJAX callbacks Fixed . Fix is already merged into 2.0.x-dev.

sethhill → made their first commit to this issue’s fork.

@Nelo_Drup, can you please provide steps to recreate? In particular, what versions of Layout Paragraphs and Mercury Editor are causing this behavior for you?

I added to the patch that @swilmes posted, displaying the view mode and preview mode by name. I also added the view_mode to the config schema and ensured that phpunit tests are still successful. This looks good from my perspective.

sethhill → made their first commit to this issue’s fork.

This looks good to me. I'm able to see the _layoutParagraphsLayout and _layoutParagraphsBuilder properties when viewing paragraphs within a LP layout or builder, respectively.

Noting that this solution is the same as what's suggested at https://www.drupal.org/project/layout_paragraphs/issues/3397222 🐛 Widget is hidden if untranslatable fields are hidden Needs review , where I also updated the builder.js to pass FunctionalJavascript tests on the latest 2.0.x code. Once that is merged this should be updated as fixed as well.

@justin2pin This looked good, although I discovered that FunctionalJavascript tests were failing with the latest 2.0.x code.

This looks good, setting to RBTC.

sethhill → made their first commit to this issue’s fork.

sethhill → changed the visibility of the branch 3265794-modal-actions-refactor to hidden.

sethhill → made their first commit to this issue’s fork.

The above approach by @nicross-com of updating the dialog buttons works as expected. In MR156 I refactored that approach to avoid setting the global variable to track the dialog, and addressed some ESLint errors that were reported in the builder.

sethhill → made their first commit to this issue’s fork.