Updated MR!58 with changes to CKEditor that allow editing when multiple embeds are in a single field. Noting that this MR also incorporates earlier changes from BaluErtl in MR39.
devanbicher, MR58 endeavors to address Paragraphs Library items by determining if the attached paragraph is within another entity. I am noticing in testing that the edit links seem to be incorrect when there are multiple items embedded—they always seem to get the uuid of the first item in the list.
sethhill → made their first commit to this issue’s fork.
Determined that an override in the site theme caused this issue. Closing.
sethhill → created an issue.
Linking to https://www.drupal.org/project/mercury_editor/issues/3495098 📌 Support for Workspaces Active , as Workspaces compatibility in Layout Paragraphs is required for compatibility with Mercury Editor.
sethhill → made their first commit to this issue’s fork.
Linking this to https://www.drupal.org/project/layout_paragraphs/issues/3472181 ✨ Make Layout Paragraphs Workspaces compatible Active , as Layout Paragraphs is where we should build in the base compatibility with Workspaces.
sethhill → created an issue.
sethhill → created an issue.
sethhill → created an issue.
sethhill → created an issue.
Installed on D11 site and appears to work. Marking RTBC.
Can we please get a review of these changes and plan for a stable D11 release? Thank you!
Incorporated these changes in a MR at 🐛 Fatal error when testing drupal 11 Active to consolidate fatal error fixes. Marking this as duplicate.
Created MR including changes from 🐛 Configuration forms are throwing errors in D11 Active that were also throwing fatal errors.
sethhill → made their first commit to this issue’s fork.
sethhill → created an issue.
Downloaded and applied this patch. Functionality appears to be working as expected in D11. Marking as RTBC.
Can we get a D11 release?
Downloaded and applied this patch, and all seems to be well. Marking as RTBC.
pbabin, that looks like code from 2.2.x.
In investigating this issue I discovered an accidental commit from the 2.2.x branch into 2.1.x that brought over a bunch of unwanted changes. I removed that from 2.1.x so it should be in better shape now, and will merge this change in once tests complete successfully.
sethhill → changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.
sethhill → changed the visibility of the branch 3505911-mercuryeditor-library-needs to active.
sethhill → changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.
sethhill → created an issue.
sethhill → created an issue.
sethhill → changed the visibility of the branch 3497979-pages-update-incorrectly to active.
Committed to 2.0.x.
sethhill → created an issue.
Tested without ME enabled, and this seems to work fine with Layout Paragraphs. Marking as closed.
Merged into 2.0.x.
sethhill → created an issue. See original summary → .
sethhill → created an issue.
Moving work to 📌 Coding standards Active on 2.0.x.
sethhill → created an issue.
Changing version to 2.0.x and will finish this. There's a lot of new code in progress.
sethhill → changed the visibility of the branch 3301458-drupal-coding-standard to active.
sethhill → changed the visibility of the branch 3301458-drupal-coding-standard to hidden.
Merged into 2.0.x.
Merged into 2.0.x.
sethhill → created an issue.
Merged into 2.2.x.
sethhill → created an issue.
sethhill → created an issue.
In many cases we do need the padding vertically so section and component controls don't overlap. The horizontal padding is needed in some cases as well, but having it as a default seems to cause more trouble. In an effort to improve the situation while we evaluate alternatives, I've created a configuration for block and inline padding, which is accessible from the Dialog Settings page (now relabeled Dialog & UI Settings). The default will be 10 pixels vertical, 0 pixels horizontal padding, but can be changed as desired by the end user.
sethhill → created an issue.
sethhill → created an issue.
This MR adds some additional contexts that can be evaluated against:
field_name: the Paragraphs reference field
entity_type: the entity type (node, taxonomy term, etc.)
entity_bundle: the entity bundle (content type, etc.)
It also modifies the application of restrictions such that all contexts are required to match in order for any restriction to apply. This allows setting granular or broad restrictions, depending on the combination.
For example:
field_rule:
context:
entity_type: node
entity_bundle: me_test_ct
field_name: field_me_test_content
region: _root
components:
- me_test_container
Will only match on the root level of the field_me_test_content field when it is on a node of type me_test_ct. All other instances of that field will not be restricted.
sethhill → created an issue.
This already works as long as the expected pattern and Mercury Editor template IDs are known. Documentation updated.
sethhill → created an issue.
We made a change in 🐛 Pages update incorrectly during saves when page caching enabled Active that addresses issues related to caching and previews. The behavior that we were seeing was that the editor was no longer attached to the correct revision of a paragraph, so when saving it appeared that changes were not saved. We cut a new 2.2-RC1 release with this change.
sethhill → changed the visibility of the branch 3497979-pages-update-incorrectly to hidden.
sethhill → changed the visibility of the branch 2.2.x to hidden.
sethhill → created an issue.
sethhill → created an issue.
Modified logic so multiple contexts can be passed that restrict paragraphs similarly.
This works as designed, I had the wrong layout name in my restriction.
sethhill → created an issue.
sethhill → created an issue.
sethhill → created an issue.
I made a small module called SDC CSS Relocator → to help with a similar issue that I was seeing. If there's anything that would make it more helpful while this issue awaits resolution, feel free to comment on that project page.
sethhill → created an issue.
The schema passes in Config Inspection but I do see 1 data error reported on the summary screen for mercury_editor.settings. It does not, however, show any errors on the detail screen and others have reported this behavior with the module. I think we should merge in and report any new errors separately. Thanks for the review!
sethhill → created an issue.
The MR should resolve schema structural errors. In reviewing, I noticed that the menu settings for Mercury behave differently from the dialog settings, in that menu is a string and dialog actually encodes/decodes YAML. I created 📌 Groups config in mercury_editor.menu.settings should be YAML instead of string Active to update that, as the current behavior works. Converting to YAML decoding would allow greater detail in validating the schema and improve user experience.
sethhill → created an issue.
sethhill → made their first commit to this issue’s fork.
We decided to go with the quick fix at the moment, as the work to change how Mercury Editor libraries are attached will require more changes than we want to make. Created 📌 Mercury Editor libraries are attached to entity edit forms even when Mercury is not enabled for them Active to capture that need for future development.