- Issue created by @sethhill
- πΊπΈUnited States sethhill
sethhill β changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.
- πΊπΈUnited States sethhill
sethhill β changed the visibility of the branch 3505911-mercuryeditor-library-needs to active.
- πΊπΈUnited States sethhill
sethhill β changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.
- πΊπΈUnited States pbabin
Hi
We are in Drupal 10.4.2 and found ourselves in a situation where we needed to use this patch to have the .reveal-on-hover for the lpb-controls to display. Previously the library wouldn't seem to trigger.
After the patch was applied we ended up getting a console error around line 192
let rolloverPaddingBlock = drupalSettings.mercuryEditor.rolloverPaddingBlock ?? defaultRolloverPaddingBlock;
.TypeError: undefined is not an object (evaluating 'drupalSettings.mercuryEditor.rolloverPaddingBlock')
Any recommendations?
- πΊπΈUnited States sethhill
pbabin, that looks like code from 2.2.x.
In investigating this issue I discovered an accidental commit from the 2.2.x branch into 2.1.x that brought over a bunch of unwanted changes. I removed that from 2.1.x so it should be in better shape now, and will merge this change in once tests complete successfully.
-
sethhill β
committed c5543213 on 2.1.x
Issue #3505911 by sethhill, pbabin: mercury_editor library needs...
-
sethhill β
committed c5543213 on 2.1.x
Automatically closed - issue fixed for 2 weeks with no activity.