- Issue created by @jrockowitz
- First commit to issue fork.
- πΊπΈUnited States jrockowitz Brooklyn, NY
For example, you need could change
mobile_presets: type: sequence label: 'Mobile preview present dimmensions' sequence: type: object label: 'Preview preset'
- to -
mobile_presets: type: sequence label: 'Mobile preview present dimensions' sequence: type: mapping label: 'Mobile preview present dimension' mapping: name: type: text label: Name width: type: integer label: Width height: type: integer label: Height
- πΊπΈUnited States sethhill
The MR should resolve schema structural errors. In reviewing, I noticed that the menu settings for Mercury behave differently from the dialog settings, in that menu is a string and dialog actually encodes/decodes YAML. I created π Groups config in mercury_editor.menu.settings should be YAML instead of string Active to update that, as the current behavior works. Converting to YAML decoding would allow greater detail in validating the schema and improve user experience.
- πΊπΈUnited States jrockowitz Brooklyn, NY
This looks good to me. Did it pass config inspection?
BTW the
groups
in mercury_editor.menu.settings.yml could be changes from a string of YAML to sequence/mapping so that it is translatable. - πΊπΈUnited States sethhill
The schema passes in Config Inspection but I do see 1 data error reported on the summary screen for mercury_editor.settings. It does not, however, show any errors on the detail screen and others have reported this behavior with the module. I think we should merge in and report any new errors separately. Thanks for the review!