New settings not in layout_details

Created on 25 July 2024, 5 months ago
Updated 12 September 2024, 3 months ago

Problem/Motivation

In ✨ Move lock settings into layout_details Fixed the settings were moved inside a layout_details element.
When updating to 2.x, the new settings are not in the layout_details element.

Steps to reproduce

Update module from 1.x to 2.x and open settings in Layout Builder.

Proposed resolution

Move the new settings in the layout_details element.

Remaining tasks

Create and review MR

User interface changes

New settings moved in the layout_details element.

API changes

-

Data model changes

-

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tim-diels
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    Moved it in the layout_settings wrapper as the name changed a little on commit.

  • Pipeline finished with Failed
    5 months ago
    Total: 147s
    #233798
  • πŸ‡ΊπŸ‡¦Ukraine Panchuk Volyn, Lutsk

    @tim-diels, thanks for your MR. I can see the test has failed.

    I will fix the test first and then back to this issue.

  • First commit to issue fork.
  • πŸ‡§πŸ‡ͺBelgium michaelsoetaert

    When using the patch, I got the following error:
    TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 174 of modules/contrib/layout_builder_lock/layout_builder_lock.module).

    I needed to add the #parents-configuration to the layout_builder_lock_regions form element to fix the issue.

  • Pipeline finished with Success
    4 months ago
    Total: 173s
    #259379
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    You both were correct that the patch provided an error.

    The extra code provided in #6 did fix the issue. Thanks for that.

    Still needs testing then :)

Production build 0.71.5 2024