Introducing dependencies between themes

Hi,

Thanks for your interest in UI Skins. This will be a nice addition.

"Needs work" status is for when some patches or MR not ready had been created. If there is no code already shared, it should be "Active".

Hello Yassine,

Thanks for your MR.

You worked on Drupal\ui_skins\HookHandler\PreprocessHtml but it would be better to keep thsi class as simple as possible and add the mechanism to the plugin manager.

Instead of duplicated the values:

      $target2 = $plugin_definition2->getComputedTarget();
      $key2 = $plugin_definition2->getKey();
      $value2 = $plugin_definition2->getValue();

You need to set a recursive call which browse the dependency tree. A theme can have multiple dependencies, and those dependencies can have dependencies.

Also, it seems this is missing:

If a dependency is listed but is not found, let's ignore it, process as usual, and push a warning log message.

Hello,

@yassrzg, a complement of the discussion we had yesterday: the logic of gathering $plugin_definitions recursively should be added in the ui_skins/src/Theme/ThemePluginManager.php and in the interface.

So it can be reused somewhere else.

Automatically closed - issue fixed for 2 weeks with no activity.