- Issue created by @joachim
- ๐ฎ๐ณIndia ayush.pandey
ayush.pandey โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ayush.pandey
Tried converting the basics to kernetTEST cases into the MR . Please review and mention the further changes to convert this fluidly.
- Status changed to Needs work
6 months ago 9:18am 20 June 2024 - ๐ฌ๐งUnited Kingdom joachim
It's core/modules/media/tests/src/Functional/ProviderRepositoryTest.php that should be converted, not the unit test. Unit tests are even quicker than kernel tests to run, so we should not be converting in that direction.
- First commit to issue fork.
- Merge request !8494Issue #3452511: Convert ProviderRepositoryTest to a kernel test โ (Closed) created by pooja_sharma
- Merge request !8495Resolve #3452511 Change to kernel providerrepositorytest โ (Open) created by pooja_sharma
Implemented ProviderRepositoryTest to a kernel test
tried to work with existing MR , however facing issue so created new MR
Please review MR 8495 , moved NR
- Status changed to Needs review
6 months ago 10:20am 23 June 2024 - Status changed to Needs work
6 months ago 10:53am 23 June 2024 - ๐ฌ๐งUnited Kingdom joachim
You need to remove the old test too.
It looks promising, but at the moment the MR doesn't show me the old test so I can't tell for sure.
Removed Functional test case ProviderRepositoryTest.php as kernel test added.
Apart from it, nothing seems to be left.
Please review, moving to NR
- Status changed to Needs review
6 months ago 11:22am 23 June 2024 - Status changed to RTBC
6 months ago 3:24pm 23 June 2024 - ๐บ๐ธUnited States smustgrave
Seems like a good conversion
@pooja_sharma this issue was tagged novice which is usually for new users. Based on your post history believe you can work on non novice issues going forward. Thanks!
Yeah sure @smustgrave, even I also keep it in mind, however later on realised it actually requires few minor changes
-
longwave โ
committed 05b9d0d0 on 10.3.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave โ
committed 05b9d0d0 on 10.3.x
-
longwave โ
committed b55abf3d on 10.4.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave โ
committed b55abf3d on 10.4.x
-
longwave โ
committed 429b5dc1 on 11.0.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave โ
committed 429b5dc1 on 11.0.x
- Status changed to Fixed
6 months ago 7:29am 27 June 2024 -
longwave โ
committed 3e3b4953 on 11.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave โ
committed 3e3b4953 on 11.x
- ๐ฌ๐งUnited Kingdom longwave UK
Backported down to 10.3.x as a tests-only change.
Committed and pushed 3e3b49539d to 11.x and 429b5dc198 to 11.0.x and b55abf3d6e to 10.4.x and 05b9d0d02b to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.