ayush.pandey ā created an issue.
Fixed in the commit dd355eb61ac89c6c8715c1bfa47229b8642bebdb and attaching the patch as well.
ayush.pandey ā created an issue.
the_g_bomb ā credited ayush.pandey ā .
ayush.pandey ā created an issue.
ayush.pandey ā made their first commit to this issueās fork.
Not able to reproduce this issue any longer. Thus, can be closed.
Able to reproduce on D10, and the MR !7 removes the error without impacting the tracking of configuration.
Just to update here, the adding once, and using 'html' as a target selector, there console doesn't show that error any longer on change of exposed filters. Tried on D10. Can be moved to RTBC.
Code seems to be fine and working for D9, as well as D10.3.x , as the version_compare provides support to lower versions of the Drupal. Can be moved to RTBC.
@sarwan_verma ā , Can you please elaborate, how you reproduced this issue specifically, and if possible, any screenshots. For Drupal 10.3, the issue is not reproducible, with or without any content in the database. Installing the module works swiftly.
Reproducible, and the patch fixes the issue swiftly as its just declaration change. Moving to RTBC
Didn't see that duplication, but incase, for fixing this issue, here's the MR . This fixes the issue (though MR has failed its rights).
ayush.pandey ā made their first commit to this issueās fork.
The issue is reproducible, when tried adding some facets search block settings to display the label of a list items, and is fixed by the MR linked in the above tagged issue in #2. Calling getBaseFieldDefinitions($entity) instead of getFieldDefinitions works fine. Can be moved to review.
Patch on comment #5 works fine on Drupal 10 development version with module version 1.0.x-dev.
Can you please provide a more defined way to reproduce this issue, as i tried this on D10, and it works fine.
Fixed the same by using the expected ?string instead of removing the condition in the MR
ayush.pandey ā made their first commit to this issueās fork.
Fixed the issue by creating the Merge Request , please check and move the issue to RTBC/Review.
ayush.pandey ā made their first commit to this issueās fork.
Here's the MR to convert it to kernel test cases. Please reivew and check, and please post here if something needs to be altered.
ayush.pandey ā made their first commit to this issueās fork.
Tried converting the basics to kernetTEST cases into the MR . Please review and mention the further changes to convert this fluidly.
ayush.pandey ā made their first commit to this issueās fork.
Tried the module version 3.3.x-dev on drupal 10.3.x-dev, and the issue is not reproducible. The group module, along with the dependent module gets enabled successfully with no issues. Please retry and check if this is fixed.
Tried the approach as mentioned above, and it's very clear that #access = FALSE will heavily impact the other module such as Commerce Wishlist ā . I pulled out your MR!4 changes and seems like a nice approach to disable the cart for that specific module functionality. Hence reviewed.
The issue is reproducible with the module version 1.2.3 and the patch fixes the issue, and the group by field reference widget form display now can be used for entity reference field, which, was earlier got stuck in ajax loop.
Tried reproducing the issue on D10, but seems like everything works fine. Please provide more concise way to reproduce the issue. It seemed like a drupal's logger factory issue, but the services are well defined . Also, please mention your drupal's version and module's.
The issue is reproducible when visiting the website with country with no postal code (tested with Benin). And the patch fixes the issue. Just the impact on the analytics might need to be refactored, if the results on the analytics has dependency on the postal codes. @bluegeek9, you can move this to RTBC, if need no other work.
MR Created for fix and replaced Pecl interface with UUiD interface
ayush.pandey ā made their first commit to this issueās fork.
Able to reproduct the issue Error: Call to undefined function c2pa_sign_check_certificate_expiration() in c2pa_sign_requirements() (line 58 of modules\contrib\c2pa_sign\c2pa_sign.install), and after applying the c2pa key pair, the module works fine.
Hi @empesan ā , The issue is reproducible on D10 with module version 8.x-1.6. The patch provided at #2 š Deprecated function: Creation of dynamic property Active fixes the issue and the similar terms work fine for both view as block & page. Attached before patch and after-patch screenshots for reference. The issue can be moved to fixed.
Hi @peachez, The issue is specific to PHP 8.2 and does not occur in earlier versions of PHP because utf8_encode() was supported in PHP versions prior to 8.2.0. The issue is reproducible and the patch in #2 fixes the issue.
Hi, The issue is reproducible, and here is the patch for the same.
ayush.pandey ā created an issue.
The issue is reproducible with module version 2.x-dev, and the patch at #3 fixes the issue and the package is being created successfully.
Hi @ravikant, Able to reproduce the issue with Drupal 10 and module version 8.x-3.1, but the issue is resolved by installing the respective version of the amp and amptheme, for ex - 8.x-3.1 of amp theme should work with amp 8.x-3.1.
ayush.pandey ā created an issue.
Hi @Gekkie, This issue is invalid now, as for Drupal 9.4 and later versions, we will be using Mailchimp Transactional Module ā instead of Mandrill.
Hi @jasonluttrell, The error message "Deprecated function: implode(): Passing glue string after array is deprecated", is coming from the Google API PHP client library itself. To fix this issue, you just need to modify the Google API client library to use the correct order of parameters in the implode() function call.
Note - A patch might won't work as the library might vary according to your local system.
Example - implode($separator, $array);
Change it to. - implode($array, $separator);
Tried the module of version 3.0.0-beta4 with Drupal 9.4 and the issue is not reproducible from the provided steps. The path '/admin/group/types/add' is working as expected. Please share if there are any other steps to reproduce the same.
ayush.pandey ā created an issue.
Tested the module with version 1.0.x-dev in D9 and the messages seems to show proper popus on Claro theme enabled. Please suggest if you used any other ways to reproduce the issue here. Uploading screenshot with claro theme enabled and message popup.
The issue is not relevant as we need to delete data related to the module before unistalling as explained the #2. The issue can now be closed.
tried the module with version 8.x-1.x-dev on D10 with PHP 8.2 and the issue is not reproducible. Installed the module and added a metatag field to article content type and it works fine.
The patch attached fixes the issue of undefined variable.
ayush.pandey ā created an issue.
You can use this patch to hide the "Manage Display" tab for module version 1.0.x-dev.
Tested the module with version 2.2.1, and the patch works fine and the function unique_field_ajax_field_widget_single_element_form_alter works fine.
Tried to reproduce the issue with module version 2.0.3 with D9 instance, and the issue is not reproducible. The AT tool is working fine and i can access the Settings page of the newly generated theme with no issues. Please specify if any other steps are used to reproduce the issue or if it's a theme specific issue.
Tried the module with version 7.x-3.2 and the issue is reproducible. The patch fixes the issue.
Tried the module with version 2.0.0 on Drupal9, and the issue is reproducible. The "summary help text" is working now with the fix in the patch.
Tested the module with version 3.0.0 on D9, and the issue seems to be not reproducible after trying multiple ways. The $node->delete() under function delete_all_content_batch_delete() seems to validate itself already for null check on (!empty($nodes_to_delete)) . Please provide steps to reproduce this (if reproducible) with drush commands.
Tried module with version 1.3.1, and the issue is not reproducible by accessing the pages admin/reports/updates or /node/add/article . Please add some more steps that was used to reproduce the issue.
There are lot of other issues occuring in the module that is very similar to the issue above. All issues are occuring due to mishandling of the array functions like array_merge and array_diff(). While exploring the module, I found one more issue, and the screenshot of it is attached below. The patch attached fixes the known issue in D9 with the module version 3.0.0
Tried reproducing the module with version 8.x-1.x-dev, and the issue is not reproducible in D9. Please provide complete steps to reproduce the issue. Also, the patch will be invalid as the patch has wrong function names. i.e "public function jsoanApiSourceValidateRequired" . The correct will be public function jsonApiSourceValidateRequired
The issue is reproducible with module version 2.0.x-dev, and the patch in comment #2 fixes the issue and everything works perfectly. Attached before and after patch screenshots.
Hi, the issue seems to not reproducible. I tried the module version 2.0.0-alpha5 with drupal 10.1 and the node gets saved successfully with the media entity. Please check once, and add complete steps if its still reproducible .
The issue is reproducible with module version 2.x-dev on Drupal 10.1. The patch fixes the issue.
Tried the module with version 8.x-1.x-dev on Drupal 10.1, and the issue is not reproducible. Please add any specific steps through which the issue can be reproduced.
The module_handler service is now available in the 1.x branch of the parent issue and can be used.
Tried the module with version 10.1.x-dev on D10, and the issue is reproducile. The patch above in comment #3 works fine and resolves all the issues in console.
Before patch ā
After patch ā
On Drupal 10.1.0 with module version
2.0.1-alpha6, the issue is reproducible. The changes in the Merge Request !8 work perfectly and the issue no longer exists after the changes applied.
Before Changes ā
After changes ā
Installed the module with version 8.x-1.0-alpha6 on Drupal 10, and the issue is reproducible. The patch in #4 ā works fine and resolves the issue.
Reviewed the changes MR!1 , but the fix don't seem to work
Meanwhile, the below changes can be added to styles.css to show the title properly.
Previous :
a {
color: #fff ;
text-decoration: none !important;
}
Changes :
a {
color: #23527c;
text-decoration: none !important;
}
Please confirm if this is what expected.
The issue is fixed as the changes are deployed on the module itself, and the issue is no longer reproducible.
Tested with the changes in MR !1, and it fixes the spaceless issue.
Please add steps to reproduce.
Tested this with drush 12.1.2.0 , with site_audit module's version 4.0.0-rc1 and the issue was reproducible. The MR changes works fine and the module no longer shows any error.
Before ā
After MR changes ā
The Like/Dislike widget with version 2.2.0 is now compatible with your custom entity when using a view to override its display. You should be able to add the Like/Dislike field to the view without any difficulties.
Tested the module with version 2.x-dev on Drupal 10 with PHP 8.1 and the issue seems to not reproducible (enabled on all forms).
I have updated the PHP version to 8.1 and the module Image Resize Filter to version: 8.x-1.1, and i am able to reproduce the issue.
The changes in the patch attached don't apply. The MR attached in
#6
š
is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in modules/contrib/image_resize_filter/image_resize_filter.module
Needs review
changes seems to work fine.
Before ā
After MR changes ā
For the module URL Alias Permissions with version: 8.x-1.4, and the issue seems to be resolved by the patch
https://www.drupal.org/files/issues/2022-11-15/3313956-4.patch ā
.
Before patch ā
After patch ā
I have explored the issue, but the issue seems not to be reproducible on the field_permission module version 8.x-1.x-dev and PHP version 8.1.
Please add proper steps to reproduce incase it is reproducible at your end.
jrochate ā
Seems that it is not reproducible. I have swithed to the PHP version 8.1 and used SpamSpan module version 8.x-1.3.
Created a new content type with a field that uses SpamSpan filter on display. Adding content to it saves the node without any issues. Please verify if this happens with any other procedures you use for the issue occurring.
Yes, I have simple_sitemap installed.
I have checked the PR, but it does not resolve the issue completely. It throws an error Class "Drupal\simple_sitemap\Controller\SimplesitemapController" not found in include() (line 17 of modules/contrib/domain_simple_sitemap/src/Controller/DomainSimpleSitemapController.php).
Also, the change added in PR, public static function create(ContainerInterface $container): DomainSitemapController , will resolve the issue for create function, but will throw error for getSitemap child function.
Please add steps to reproduce.
Please add steps to reproduce so i can verify the fix as per the expectations.