- Issue created by @ayush.pandey
- Assigned to sarwan
- Issue was unassigned.
- 🇺🇸United States danflanagan8 St. Louis, US
Looks like the trace includes calls within the
crossword_pseudofields
submodule. I wonder if there's some escape that needs to happen if something is empty? - Status changed to Needs review
8 months ago 7:19am 18 October 2023 - last update
8 months ago 74 pass, 2 fail - 🇮🇳India vsujeetkumar Delhi
Based on the issue description created a patch and add check if the filed has no value. Please have a look and review.
- Status changed to Needs work
8 months ago 12:44pm 18 October 2023 - Status changed to Needs review
8 months ago 6:49am 19 October 2023 - last update
8 months ago 79 pass - 🇮🇳India vsujeetkumar Delhi
Patch created with the new approach, Try to fixed the test cases, Please have a look.
- Status changed to Needs work
8 months ago 12:52pm 19 October 2023 - 🇺🇸United States danflanagan8 St. Louis, US
The change to CrosswordPseudofieldsFormatter in #8 looks great.
The other changes aren't needed. CrosswordFormatter and CrosswordSolutionFormatter already return an empty array if getEntitiesToView() returns an empty array. Let's undo those changes.
- Status changed to Needs review
8 months ago 1:12pm 19 October 2023 - last update
8 months ago 79 pass