Delhi
Account created on 11 April 2015, over 9 years ago
#

Merge Requests

Recent comments

🇮🇳India vsujeetkumar Delhi

Added support for Drupal 10 in info.yml file. Please have a look and verify.

🇮🇳India vsujeetkumar Delhi

Re-roll & Convert Patch #82 into MR. Please have a look.

🇮🇳India vsujeetkumar Delhi

#82 not applied on 11.x, Re-roll patch needed.

🇮🇳India vsujeetkumar Delhi

Worked on fail test and found that the test are passing on local so rerun the test again on #69 and its pass, So as per the #70 moving it to RTBC.

🇮🇳India vsujeetkumar Delhi

Convert Patch #29 into MR. According to #33. Please have a look.

🇮🇳India vsujeetkumar Delhi

vsujeetkumar made their first commit to this issue’s fork.

🇮🇳India vsujeetkumar Delhi

I have updated the MR for 11.x. Please have a look.

🇮🇳India vsujeetkumar Delhi

#34 not applied on 11.x, Re-roll patch needed.

🇮🇳India vsujeetkumar Delhi

Fixed the failures (CCF Issues) in #27.

🇮🇳India vsujeetkumar Delhi

@GlennDW Interdiff should be there in #34, It's help others to understand the changes you have done.
@jOpdebeeck diff required while we rerolling. Please check the doc .

🇮🇳India vsujeetkumar Delhi

@welly As mentioned in #49, reverted the file changes for 'MessageViewBuilder.php' & 'LayoutBuilderEntityViewDisplay.php'. During the investigation last I have added those, but now its reverted and try to fix the remaining tests.

🇮🇳India vsujeetkumar Delhi

Adding missing interdiff. Please have a look.

🇮🇳India vsujeetkumar Delhi

Fixed the CCF issue by removing the deprecated method. Please have a look

🇮🇳India vsujeetkumar Delhi

Fixed the CCF issue, Please have a look.

🇮🇳India vsujeetkumar Delhi

Test fails because of 'type' issue, Try to fixed that.

🇮🇳India vsujeetkumar Delhi

Fixed the failed test cases, Please have a look.

🇮🇳India vsujeetkumar Delhi

#99 patch fails to apply, created updated path without fails. Also on below comment I am also thinking the same for now we can use #94 and do followups on help topics, Here we need expert advise.

At this point we may either use the patch at #94 and open a follow-up specifically for help topics, that my use the code on the patches in this comment; or continue here.

🇮🇳India vsujeetkumar Delhi

Fixed the CCF issues.

🇮🇳India vsujeetkumar Delhi

Patch created with the new approach, Try to fixed the test cases, Please have a look.

🇮🇳India vsujeetkumar Delhi

Based on the issue description created a patch and add check if the filed has no value. Please have a look and review.

🇮🇳India vsujeetkumar Delhi

Fixed test cases, Please have a look.

🇮🇳India vsujeetkumar Delhi

Addressed #92, Used Html::load() wherever we use HTML5(). Patch created, Please have a look.

🇮🇳India vsujeetkumar Delhi

Fixed the failed test cases, and other coding standard issue, Please have a look.

🇮🇳India vsujeetkumar Delhi

Fixed the failed test cases, and 8 coding standard issue, Please have a look.

🇮🇳India vsujeetkumar Delhi

Added Interdiff between #73 and #77.

🇮🇳India vsujeetkumar Delhi

Fixed the CCF issues, Keeps as in 'Needs Work' to fix the fail test case and need to address #75.

🇮🇳India vsujeetkumar Delhi

Thanks everyone to participage and fix this issue.

🇮🇳India vsujeetkumar Delhi

Also not 100% about the test fix in #88. Is that what HTML5 requires?

@smustgrave, Will take the reference from "related & committed" issue in #86, Please have a look on file "core/modules/filter/tests/src/Kernel/FilterCaptionTwigDebugTest.php" in the related issue and advise.

🇮🇳India vsujeetkumar Delhi

Fixed the test case, Please have a look.

🇮🇳India vsujeetkumar Delhi

Re-roll patch created as per #86. rdf changes has been removed from the patch as it is not part of core now.

🇮🇳India vsujeetkumar Delhi

Missing Trait file in #449, Added and fixed the CCF issues. Keeps as in 'Needs Work' to address #450.

🇮🇳India vsujeetkumar Delhi

Tried to rebase the base to 9.5.x, Something went wrong but not sure, So please have a look and advise. Created an MR, Please ignore if not required.

🇮🇳India vsujeetkumar Delhi

Re-roll patch created for 11.x. And keeps as in "Need work" because some of the comments are still unaddressed.

Some of the theme files changes has been removed because of those are not part of current version.

🇮🇳India vsujeetkumar Delhi

Re-roll patch created for 11.x. Keeps as in "Needs work" because of unaddressed comment #33.

🇮🇳India vsujeetkumar Delhi

Re-roll patch created for 11.x, We have added some missing JS files according to #26 and removed es6.js files with reference of this document . Keeps as is "Needs work" because we have some unaddressed comments above.

🇮🇳India vsujeetkumar Delhi

@Prem Suthar, Interdiff is missing in #39, We should add that along with the patch. Its help to the reviewers to find the difference and what are the changes we have made from last patch. Also some Tests fails because some of the files are missing in the patch. Please compare with #26.

🇮🇳India vsujeetkumar Delhi

Patch created, Fixed the fail tests. Keeps as is in "needs work" to address the #69.

🇮🇳India vsujeetkumar Delhi

Addressed #64, Patch created, Please have a look.

🇮🇳India vsujeetkumar Delhi

Fixed the CCF issues along with deprecation message, Patch created, Keeps is as "Needs works" to fix the failed test cases.

🇮🇳India vsujeetkumar Delhi

Fixing the test, Keep as in "Needs work" because of fail tests.

🇮🇳India vsujeetkumar Delhi

Fixed CCF issue, Addressed #15, Please have a look.

🇮🇳India vsujeetkumar Delhi

This is not true. There is an optional $delta argument.

In #151.1, True $delta argument is optional, As per my understanding, Either we should update the comment like

By default the first delta can be accessed with this method.

or we can remove this line from the comment.

🇮🇳India vsujeetkumar Delhi

Re-roll patch created, Keep as is in 'Needs works' state, for addressing #4.

Production build 0.71.5 2024