Skip spellcheck for 20 nonsense words that are parts of hashes

Created on 3 August 2023, 11 months ago
Updated 24 October 2023, 8 months ago

Problem/Motivation

dictionary.txt contains 17 words such as "sebe" which are accidentally treated as text, but they come from hashed values:

     $session2_id = 'aSebeZ52bbM6SvADurQP89SFnEpxY6j8';

Steps to reproduce

See dictionary.txt.

  1. aiufyfh
  2. cjds
  3. depcn
  4. exoshbm
  5. hisu
  6. hisue
  7. iopt
  8. jnoub
  9. oypa
  10. pdma
  11. qzzz
  12. sebe
  13. sxto
  14. szwr
  15. wmet
  16. xjkm
  17. xyabz
  18. yqpr
  19. yuqk
  20. zwjhek

Proposed resolution

Ignore these lines as they do not contain spelling errors, or replace them if they are only used in tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.2

Component
Other 

Last updated about 4 hours ago

Created by

🇬🇧United Kingdom longwave UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @longwave
  • Status changed to Needs review 11 months ago
  • last update 11 months ago
    Patch Failed to Apply
  • 🇬🇧United Kingdom longwave UK

    I couldn't find an automatic way of doing this but I looked through the entire dictionary for words that didn't look like words at all, and found all of these.

    BigPipePlaceholderTestCases contains so many that I think it's just worth disabling spellcheck for the entire file instead of trying to ignore individual lines or words.

  • Status changed to Needs work 11 months ago
  • 🇬🇧United Kingdom longwave UK
  • 🇳🇿New Zealand quietone New Zealand

    Oh, I like the scoping!

    1. +++ b/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php
      @@ -3,7 +3,8 @@
      +// cSpell:disable
      

      Doing this for a whole file caught my eye. I'd like to avoid that.
      In my testing there are 4 spelling errors found, timetime, timecurrent, Ulwa and Vxezb, in 11 lines. I see three options
      1) 1 ignore line at the top
      2) 11 disable-next-line.
      3) 1 ignore at the top for timetime and timecurrent and the remaining are disable-next-line.

      Of those I prefer '3' because it is easy to read the two time words and the disable lines will be right above the single line they effect. Leaving the rest of the file spellchecked.

      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:212:44 - Unknown word (timecurrent)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:212:56 - Unknown word (timetime)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:214:57 - Unknown word (timecurrent)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:214:69 - Unknown word (timetime)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:222:14 - Unknown word (timecurrent)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:222:26 - Unknown word (timetime)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:226:12 - Unknown word (timecurrent)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:226:24 - Unknown word (timetime)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:234:55 - Unknown word (timecurrent)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:234:67 - Unknown word (timetime)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:257:174 - Unknown word (Ulwa)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:262:203 - Unknown word (Ulwa)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:264:219 - Unknown word (Ulwa)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:276:164 - Unknown word (Ulwa)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:280:174 - Unknown word (Ulwa)
      /var/www/html/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php:312:191 - Unknown word (Vxezb)
    2. +++ b/core/modules/system/tests/src/Kernel/Entity/EntityReferenceSelectionReferenceableTest.php
      @@ -8,6 +8,8 @@
      +// cspell:ignore xyabz
      

      I wondered about this unusual 'word' as well. After reading the test file this makes sense, the string is used in multiple places. I think this is the best option for readability.

  • 🇮🇳India vsujeetkumar Delhi

    Re-roll patch created, Keep as is in 'Needs works' state, for addressing #4.

  • last update 9 months ago
    30,158 pass
  • 🇳🇿New Zealand quietone New Zealand

    @vsujeetkumar, when rerolling a patch it is good practice to add an interdiff or diff and to comment on anything unique about the reroll. There are instructions at Rerolling patches .

    I created the diff between #2 and #5 and have uploaded it.

    This also needed another reroll.

    Also, I intend to switch to an MR.

  • last update 8 months ago
    30,425 pass
  • Status changed to Needs review 8 months ago
  • 🇳🇿New Zealand quietone New Zealand

    Added some strings used in tokens.

  • 🇳🇿New Zealand quietone New Zealand
  • last update 8 months ago
    30,425 pass
  • @quietone opened merge request.
  • last update 8 months ago
    30,426 pass
  • 🇳🇿New Zealand quietone New Zealand
  • Status changed to RTBC 8 months ago
  • 🇺🇸United States smustgrave

    words in the issue summary match the MR.

    Changes seem fine to me!

  • last update 8 months ago
    30,434 pass
    • longwave committed 58beaf2a on 10.2.x
      Issue #3379121 by quietone, longwave: Skip spellcheck for 20 nonsense...
    • longwave committed c7e751a5 on 11.x
      Issue #3379121 by quietone, longwave: Skip spellcheck for 20 nonsense...
  • Status changed to Fixed 8 months ago
  • 🇬🇧United Kingdom longwave UK

    Committed and pushed c7e751a532 to 11.x and 58beaf2ab4 to 10.2.x. Thanks!

    Did not backport cleanly to 10.1.x.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024