Clean up locale CSS in line with our CSS standards

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I have refactored the CSS file.
1. Replaced all the ID selectors with class selectors.
2. margin-left, right properties replaced with margin-inline-start, end so it can be used in LTR & RTL.

Please review.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed CCF and attached interdiff for same.

There are few instances of hardcoded colors. Should those be variables or least the 6 character colors?

Updated #61 according to #62

Added color variables and added interdiff with #61, for same. please review

Thanks @Gauravv!

Just adding a space because I keep thinking this is about inline styles.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolled the patch.

Reroll seems fine.

The last submitted patch, 69: 2485497-69.patch, failed testing. View results →

Worked on fail test and found that the test are passing on local so rerun the test again on #69 and its pass, So as per the #70 moving it to RTBC.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Nitin shrivastava → made their first commit to this issue’s fork.

#69 still applied cleanly so this could of been put back into RTBC.

Manually tested this and all looks fine, but there is one LTR comment that I think is out of place, and we should fix it while we're here.

sagarchauhan → changed the visibility of the branch 11.x to hidden.

sagarchauhan → changed the visibility of the branch 2485497-clean-up-locale to hidden.

sagarchauhan → changed the visibility of the branch 11.x to active.

sagarchauhan → changed the visibility of the branch 2485497-clean-up-locale to active.

Rebased the MR for pipeline break.

Feedback appears to be addressee

It'd be great to do 📌 Enforce the use of CSS Logical Properties in core Needs work first as that would enforce quite a few of the changes.

xjm → credited chrisfromredfin → .

Postponing on 📌 Enforce the use of CSS Logical Properties in core Needs work per #85.

Also saving issue credits, which took a long time since this has been reviewed by a lot of different people over the years. I made an educated guess on which "cwells" was mentoring @reedcodes in Boston. :)