- 🇺🇸United States Chris Matthews
FWIW, the proposed resolution to make the text of the button configurable through a field in the widget settings (of the "manage form" tab) so that users can override the default text of "Add media" doesn't feel quite right as a CORE UI settings, seems like it might be better suited for contrib. If anything, I think this issue should be re-scoped to provide more sensible defaults as suggested by yoroy → in #22 ✨ Let users configure the text of the "Add media" button Needs work .
- 🇮🇳India vsujeetkumar Delhi
#34 not applied on 11.x, Re-roll patch needed.
- last update
almost 2 years ago 30,548 pass, 2 fail - 🇩🇪Germany chr.fritsch 🇩🇪🇪🇺🌍
chr.fritsch → changed the visibility of the branch 3169956-let-users-configure to hidden.
- 🇩🇪Germany chr.fritsch 🇩🇪🇪🇺🌍
chr.fritsch → changed the visibility of the branch 11.x to hidden.
- 🇩🇪Germany chr.fritsch 🇩🇪🇪🇺🌍
I created an updated MR, fixed the tests and added an assertion to ensure the form setting is there.
- 🇺🇸United States smustgrave
Interesting feature!
Since this is introducing a new config key will probably need a post update hook that using a ConfigImporter setup.
Any default yml files need to be updated?