- 🇺🇸United States DamienMcKenna NH, USA
FYI here's how I'm using the hook to remove the width and height from the iframe, so that its display can be managed using CSS.
/** * Implements hook_oembed_resource_data_alter(). */ function mymodule_oembed_resource_data_alter(array &$data, $url) { // @see https://www.drupal.org/project/drupal/issues/3042423 if (str_contains($url, 'youtube.com/oembed')) { // Remove the width and height attributes from the oembed iframe so that // they can be set via CSS. Note; do not remove the thumbnail width and // height as they are required. unset($data['width']); unset($data['height']); $data['html'] = str_replace([' width="200"', ' height="113"'], '', $data['html']); } }
- 🇺🇸United States DamienMcKenna NH, USA
For anyone who needs it, this is #106 rerolled for 10.2.x.
- 🇦🇺Australia griffynh Sydney
Hola, this came up again in the #bugsmash channel as the Views daily triage target.
As we've had no update in over two and a half years, if there's no update in the next three months, this issue may be closed.
- 🇺🇸United States smustgrave
Seems the title update and issue summary update are still needed.
Also fixes should be in MRs vs patches.
- 🇮🇳India mohit_aghera Rajkot
I've addressed the feedback in #40
I think node tests aren't required as such.Fixed a few more things in the PR
- convert it to use OOP hooks
- Fixed a few things in tests.
- Tests seems green now.Hiding all the patches in favour of MR.
- @mohit_aghera opened merge request.