Stop adding specific CSS to Media form and use ContentEntityForm regions instead

Created on 17 October 2017, about 7 years ago
Updated 25 January 2023, almost 2 years ago

Problem/Motivation

Follow-up to #2916741: Don't try to include Media CSS library if Media Entity 1.x is being used β†’ .

There is currently a @TODO to remove the form alter inside seven.theme that adds some specific CSS to media entity forms. This was pending on #2892304: Introduce footer region to ContentEntityForm β†’ , which has now landed, so we can proceed to clean up this @TODO.

Proposed resolution

Use '#group' => 'footer' instead of adding specific CSS to the form.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain marcoscano Barcelona, Spain

Live updates comments and jobs are added and updated live.
  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    So looking at the IS and comments this appears to be specific to seven to me? Which was removed in D10

    If you disagree please move back with an updated issue summary

    Thanks

Production build 0.71.5 2024