Strange I didn't see that in my browser the aria-label will check why it isn't there.
mschudders → created an issue.
Dear @mably,
Well that would work however. I strongly think and suggest that the module should be accessible (a11y) by default. As Drupal Core also is.
The other party that you mentioned in the other ticket did they do a manual accessibility test or an automated?
May I ask what they said about the change regarding the remove filter (X right now-> changing to Remove filter ABC X)
Thanks
Dear mably;
It seems (didn't check it thoroughly) most items have already been done?
Could you elaborate and what still needs to be done?
Thanks
Dear,
I don't understand that when you access(or read or get a list of links of the page) the links, a link with just "X" would be considered accessible and even user friendly.
A hook to alter would be sufficient in my case then yes.
What path are we going to follow,
1/ A Alter hook
or
2/ Having it as a configurable option.
1/ Would suit my needs.
2/ Would still need tweaking then afterwards.
Kind regards,
mably → credited mschudders → .
Please see merge request
> Needs review
mschudders → created an issue.
Needs to be review if OK.
Merge request provided.
mschudders → created an issue.
mschudders → created an issue.
added patch for older version 3.1.X:
https://git.drupalcode.org/issue/file_mdm-3319733/-/commit/7a33f4f4bb71b...
Branch: 3319733-out-of-memory-error-when-editing-node-too-many-large-fields Compare
Will test if the bumping of fileye fixes the issue.
mschudders → made their first commit to this issue’s fork.
closing.
Fixed.
added to latest DEV.
dropped 8 & 9.
Added 11
added & fixed on latest DEV.
mschudders → created an issue.
Merged.
Thanks.
added to latest DEV.
thx, merged.
not going to do anymore, was for 1.0.x
closing
done.
applied patch + dropped D8 +D9 support.
'ill pick it up next week.
doesn't apply for 2.0.x
This has been removed.
Only applies to 1.0.x
Closing.
Merged?
> Fixed.
created 2.0.x
Added new TAG and thus a new release.
reflected on project page.
closing
closing
done fixed
created new release for V2 as well.
options:
hook/event/alter > So the module who puts the values there should "hook in" and translate value to label?
mschudders → created an issue.
merged!
Thanks.
pushed on DEV.
is working well, used for several months in PRD.
closing
if you could resolve the last conflicts so I can merge the branch that would be great.
Thanks
merged looks good
thanks
If this is an option that can be toggled (and this not by default) I can agree on this.
But right now I don't think this is good to set by default.
pushed to DEV.
Thanks.
mschudders → created an issue.
kriboogh → credited mschudders → .
up to date with latest changes now.
Putting in Needs review.
mschudders → made their first commit to this issue’s fork.
Thanks!
mschudders → created an issue.
added to DEV.
Fixed.
mschudders → created an issue.
Merged!
Thanks
Fixed
Great thanks!
mschudders → created an issue.
Merged.
shouldn't be the responsability of this contrib
todo check config.
mschudders → created an issue.
Is indeed a nice request. Maybe if we have some time in the future we could implement it.
Mschudders → created an issue.
closing and marking as fixed
I've added this to the DEV branch.
please provide MR.
thanks
@tim shall I resolve these?
Cheers
closing
looks good merged.
Hey,
Well since it's just a Plugin implementation, which isn't loaded when needed, I don't think it's necessary to create a separate submodule.
Normally the work for the webform element is done.
could you test it please? (Didnt test the autocomplete) other features seem to work properly.
Thanks!
Kind regards,
Marking as fixed in the meantime.
assign to me && needs work
update:
V1 working element added. Need extra features, more testing, and making sure everything works,
this is just a prototype.
in dev.
alright, i'll have a crack at it. (dev branch)
Mschudders → created an issue.
That's not the purpose of datalist or a select element.
Only the options inside of the list should be allowed.
put to needs work based off last comment.
fixed status.
fixed.
Mschudders → created an issue. See original summary → .
Mschudders → created an issue. See original summary → .
Added another fix for this on latest DEV branch.
Could you test if that works for you?
Thanks.
the help is a bit slim. If more information is added I could add it (also a link to the drupal page)
only from 9 and up is supported. So this is outdated.
closing ticket since I cleaned up the defaults in the form and this is resolved.