Threshold Percentage 100 is useless

Created on 1 March 2023, almost 2 years ago

Updated 26 August 2024, 4 months ago

Problem/Motivation

We also noticed that some clients are using Threshold Percentage 100 as a setting, expecting that 100% similar values are marked as spam. But that couldn't happen, even with a 100% similarity percentage 100 is not larger than 100:

https://git.drupalcode.org/project/spamaway/-/blob/2.0.0/src/Plugin/Webf...

Proposed resolution

Replace Greater Than (>) with Greater than or equal to (>=).
Or improve the description text, so it's clear that Threshold 100 cannot be used as a setting.

🐛 Bug report

Status

Postponed: needs info

Version

2.0

Component

Code

Created by

dejan0

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @dejan0
Comment over 1 year ago →
🇧🇪Belgium mschudders
thanks for reporting.

We will implement ">="
@mschudders opened merge request.
Status changed to Needs review over 1 year ago7:09am 24 March 2023
Comment over 1 year ago →
🇧🇪Belgium mschudders
@dejan0 could you verify if this suits/work for you?

> https://git.drupalcode.org/project/spamaway/-/merge_requests/3/diffs

Thanks
Status changed to Postponed: needs info 4 months ago1:23pm 26 August 2024
Comment 4 months ago →
🇧🇪Belgium mschudders

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024