I also noticed that everything in $_GET is also available in $view->getExposedInput(), at least in my cases. Could we simply replace $_GET with $view->getExposedInput()?
Please find an attached patch.
dejan0 → created an issue.
dejan0 → created an issue.
grienauer → credited dejan0 → .
jjchinquist → credited dejan0 → .
please find the patch attached.
dejan0 → created an issue.
dejan0 → created an issue.
please find the patch attached
dejan0 → created an issue.
ah sorry, something was missing in the previous patch. Please find attached a fixed one
please find the patch attached
dejan0 → created an issue.
That solution doesn't work for us (Drupal 10.2) because all taxonomy terms on the website are showing a 404 Not Found page now.
Here's a new (temporary) solution
re-roll the patch against older drupal/sidekick version
please find the patch that removes most of those API calls
dejan0 → created an issue.
The small patch is available here. However, upon further consideration, I'm unsure if it's a good idea to allow this to be changed. Modules typically use it in hook_mail() to filter out their messages. Allowing other modules to change it in between might not be ideal. Let's see what others think.
dejan0 → created an issue.
Temporarily patch is here, it disables #limit_validation_errors. Not ideal, as validation errors now might be triggered during AJAX call (Sidekick button), and visible on the next page. And that might be just confusing for editors... But yes, at least Sidekick now works, and no more errors. Let's see if we can find a better solution here
dejan0 → created an issue.
@grienauer this is done now, 2.0.x branch is created and the 2.0.0-alpha1 version is released.
Feel free to mark old versions/branches as unsupported.
So, patch #9 worked correctly only for the first level of collection fields. But collection fields can be nested, so field_collection fields themselves can have another field_collection field as a child, and so on.
Please find attached an improved version of the previous patch, so it recursively lists all nested collection fields/values.
Again, you have to apply the https://www.drupal.org/node/1881670#comment-10473816 → patch before.
sorry, wrong patch file :( Please find the correct one attached.
please find the patch attached.
dejan0 → created an issue.
dejan0 → created an issue.
dejan0 → created an issue.
dejan0 → created an issue.
As said in the task description, If we add field storage definitions into thunder_update_8322.yml, the error is gone and new fields are created on the Basic page content type. Please find the patch attached