Contrib.social

Incorrect data type usage for queued_time

Open on Drupal.org →
Created on 11 October 2023, 9 months ago
Updated 23 October 2023, 8 months ago

Problem/Motivation

When freshly installing the module, it used the install config where queued_time is set as 1500 as integer.
The form is a textfield and should be a number field as also the default to fallback to is an integer.
Saving the form will save the value as string when entered or FALSE when empty. Both are incorrect and should be altered.

Having a textfield allows to enter other values than a number and breaks the site.

Steps to reproduce

Case 1:

  • Install the module
  • Go to the settings form at admin/config/content/layout-builder-extras-live-update-settings
  • Save the form with default or another value
  • Export the config and see the value being a text string

Case 2:

  • Install the module
  • Go to the settings form at admin/config/content/layout-builder-extras-live-update-settings
  • Save the form without a value
  • Export the config and see the value being FALSE

Proposed resolution

Fix the default value in the settings form when no value is given at load or save of the form

Remaining tasks

Create and review patch

User interface changes

-

API changes

-

Data model changes

Data type of the queued_time will change.

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

🇧🇪Belgium tim-diels Belgium 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024