🇧🇪Belgium @leanderjcc

This wasn't working for me as the attribute should be "data-dialog-options" instead of "data-dialog-option".

Thus, the correct example being:
<a href=”/node/3” data-dialog-type=”modal” class=”use-ajax” data-dialog-options="{&quot;width&quot;:800, &quot;height&quot;:500}">Node 3</a>

As form element:

$form['somelink'] = [
  '#type' => 'link',
  '#title' => 'Some link',
  '#url' => $url,
  '#attributes' => [
    'class' => [
      'use-ajax',
    ],
    'data-dialog-type' => 'modal',
    'data-dialog-options' => Json::encode([
      'width' => 800,
      'height' => 500,
    ]),
  ],
];

Patch from #8 applied and solved the issue for us on a view without AJAX (2.0.0-alpha3).

Regarding #22:

Since 10.2 (see https://www.drupal.org/node/3376447 → ) the decimal data definition is available and used on a DecimalItem.

Is this issue still relevant?

The issue is that the site setting entity type defines a canonical. This seems to be fixed in #3357022, but a new version with that fix is not yet released. Using the following patch created from the merge request in that issue should resolve the issue.

I can confirm that after upgrading to 10.2 the site settings menu link stopped working.

I am checking what the issue is and have determined that the canonical route is not built in DefaultHtmlRouteProvider because the hasViewBuilderClass returns FALSE.

Next step being decide of the canonical link is needed? If not that can be removed, else a ViewBuilderClass should be provided.

I stumbled upon this again and ended up using the following the make the field not required in the inline entity form of a commerce order item.

function hook_entity_bundle_field_info_alter(&$fields, \Drupal\Core\Entity\EntityTypeInterface $entity_type, $bundle) {
  if ($entity_type->id() == 'commerce_order_item' && !empty($fields['purchased_entity'])) {
    $fields['purchased_entity']->setRequired(FALSE);
  }
}

leanderjcc → created an issue.

I've created a MR that adds a composer.json that defines the conflict with drupal/layoutbuilder_extras 1.*, however I was not able to test this as I am unsure how to.

If someone else could test this, that would be great :)

To fast, selected the wrong status :)

This is blocked by 🐛 Provide a correct config schema Needs review , but here is the patch with the necessary changes applied on those changes.

Needs review.

Set the schema for 'queued time' to the current type for now so it can be fixed in 🐛 Incorrect data type usage for queued_time Active .

I'll pick this up

leanderjcc → created an issue.

Minor change so I don't see why this would be blocked. Still needs review tho :)

leanderjcc → created an issue.

Resolved after applied MR

Moving to RTBC :)

leanderjcc → created an issue.

Can confirm that the hover state is indeed broken with the MR.

leanderjcc → created an issue.

Grevil → credited leanderjcc → .

There seemed to be non-english text that didn't belong.

That is because the patch needs some work

I've created a patch that solves this issue, however I am having trouble building the changes. If anyone could apply the patch, build the changes and add the new patch that would be great!

leanderjcc → created an issue.

Patch from #5 did not add groups to userinfo.

Adding patch that fixes this issue.

The role mapping needs some work as this didn't seem to work.

I created a patch based on the above MR to support the 2.0.x branch.

Patch needs review.

Hi,

I too had this issue with a form that used ajax callbacks and an ajax form submit with multiselect version 2.0.0-beta2.

The above patch from Rajdeep still applied and fixed this issue for me.

Kind regards,
Leander

Linked the wrong patch, adding the correct one

leanderjcc → created an issue.

We are noticing some unexpected behaviour with the module.

When we have the link and anchor functionality enabled on our WYSIWYG and we add for example 'https://www.google.be/' in the text it will automatically see this as a link, but also as an anchor. I would expected it to make it a link, but not the anchor. Same goes for other links such as an email address.

This was the case for both version 0.1.0 and 0.2.0 of the plugin.

Also since 0.2.0 we see that some styling has been enabled that doesn't fit very well imo (see screenshot '0.2.0-anchor-style'). I'm using gin dark-theme where it does not make text very readable. In gin light-theme it is better, but I believe theming should be added as little as possible to the library.

A little cleaner proposal I would make instead of the current styling is adding something like a dashed line (see screenshot 'proposed-anchor-style'). This is something that we used with the 0.1.0 functionality to differentiate anchor links from normal links. In our case, the client was happy with the look.

We used the following CSS for this:

.ck a[id] {
  text-decoration: underline dashed;
  text-underline-offset: 0.3em;
}

Also +1 for the proposal on #49 for adding the library to the module.

Hi, I tried out the merge from Dylan and was able to get this to work with the following steps:

1. Composer require drupal/anchor_link:^3
2. Add a patch for the MR (https://git.drupalcode.org/project/anchor_link/-/merge_requests/5.patch)
3. The repository did not seem to automatically added for me so I manually added the following snippet to the repositories section in my composer.json
   

   {
         "type": "package",
         "package": {
           "name": "northernco/ckeditor5-anchor-drupal",
           "version": "0.1.0.",
           "type": "drupal-library",
           "dist": {
             "url": "https://registry.npmjs.org/@northernco/ckeditor5-anchor-drupal/-/ckeditor5-anchor-drupal-0.1.0.tgz",
             "type": "tar"
           }
         }
       }

   After this I required the library northernco/ckeditor5-anchor-drupal

4. I tried enabling the module but was getting an error that the fakeobject package was required. Since I'm not interested in the CKE4 functionality I removed the dependency fakeobject:fakeobject in anchor_link.info.yml with a patch. After the patch was applied I had no problem enabling the module
5. Now all left to do was add the anchor link button in my text editor.
6. After adding the button I could use it in my WYSIWYG editors to add an anchor link and via the link functionality I could link to it by using the anchor name with the # in front.

Perhaps related to https://www.drupal.org/project/drupal/issues/2872518 →

Should we try something as proposed in https://www.drupal.org/project/drupal/issues/2872518#comment-13767800 → ?

I've tested the patch out but it seems that there is validation on this which prevents it from being saved.

Is it an option to remove the required attribute on the field when editing an order item (but keeping it required when adding one).

Perhaps we can make this change in the same place where the field is disabled for edits?

I've added a merge request where I applied this change.

Hi,

I've stumbled upon this issue as well.

Is it an option to remove the required attribute on the field when editing an order item (but keeping it required when adding one).

Perhaps we can make this change in the same place where the field is disabled for edits?