Using a media entity reference field referencing a non existent image file, will throw an error

Grevil → credited leanderjcc → .

Alright, first review, please.

We are currently not displaying the image at all, if the path is NULL. Maybe we should show Markup inside the template instead? Also the logger message can not be more specific unfortunately.... We do not have any way to identify the current ImageDTO object affected, because every attribute is made up by their "item" (aka image file or media object). We could reference the media entity as, if the file is missing, the media entity won't be NULL. BUT if it is a file we apply photoswipe on, the logger will log NULL as the referenced item.

Please decide, what to do here @Anybody. Afterward, I can write some tests.

Well done! :)

Let's test-only to ensure the tests failed before.

Sorry, I had to refactor those media tests... They were really inefficient and had so much duplicate code in them...

Yea... I don't know why, but I can not reproduce the issue inside tests... deleting the referenced file and even the WHOLE media entity doesn't do anything with the node! 😅
No idea, already cleared the caches and everything. Might just be a test only thing.

I think I have to somehow choose another way on how to display the error.

No way to replicate this test wise. I tried everything. Manually setting a wrong uri will display the image, setting the file uri "NULL" will throw an SQL error, using a non-existing target id will throw an error, deleting the file which is referenced will display the image...

No idea. I could only replicate this manually through the UI. But I don't want to do that test wise...

I simply removed the test. Should we move the rest of the test refactor inside its own issue? Review pls.

Automatically closed - issue fixed for 2 weeks with no activity.