- Issue created by @mably
- @mably opened merge request.
- 🇫🇷France mably
This issue should probably be split in multiple sub-issues:
- Use multiple twig files to simplify override in themes.
- Add a hook allowing to alter filter items individually.
- And finally use previous issues to implement the a11y improvements.
- 🇧🇪Belgium mschudders
Dear mably;
It seems (didn't check it thoroughly) most items have already been done?
Could you elaborate and what still needs to be done?
Thanks
- 🇫🇷France mably
@mschudders do you mean that using a dedicated a11y submodule could be ok for you?
- 🇧🇪Belgium mschudders
Dear @mably,
Well that would work however. I strongly think and suggest that the module should be accessible (a11y) by default. As Drupal Core also is.
The other party that you mentioned in the other ticket did they do a manual accessibility test or an automated?
May I ask what they said about the change regarding the remove filter (X right now-> changing to Remove filter ABC X)
Thanks
- 🇫🇷France mably
Temesis did a full manual audit of our site, including the views filter summary part.
As I said earlier, the "X" link was ok as long as it included a valid aria-label attribute "Remove filter xxx".
You can verify in Chrome dev console that the link will be rendered using the aria-label attribute instead of the "X" content.
The link is also properly vocalized using the aria-label on Mac with VoiceOver.
- 🇧🇪Belgium mschudders
Strange I didn't see that in my browser the aria-label will check why it isn't there.