Contrib.social

Media entity translations do not adhere to status (published/unpublished)

Open on Drupal.org →
Created on 4 July 2023, 11 months ago
Updated 23 January 2024, 4 months ago

Problem/Motivation

When you have a translated Media entity, for example file and when you change status of a translated media entity the status does not change.

Update:
It works via the "content_translation" status checkbox (location in it's own section in html) but I do find this quite odd. Node and taxonomy and other don't work like that. So for UX I would definitely streamline this.

Question remains, because the tests that fail look for this content_translation_status field, if this is indeed okay?!

Steps to reproduce

  1. For a media entity type set translated to true
  2. Translate a media entity so you have 2 languages for an entity
  3. Change Status on one entity and see that it does not reflect your changes (it does work with VBO though)

Proposed resolution

Add a translation handler to Media like on Node, Taxonomy, ....

Remaining tasks

Review patch where I've added the translation handler.

Release notes snippet

Media entity translations adhere to status

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Media  →

Last updated 1 day ago

Created by

🇧🇪Belgium Mschudders

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Mschudders
  • Comment 11 months ago →
    🇧🇪Belgium Mschudders

    code mostly taken from the TaxonomyTranslationHandler.php

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update 11 months ago
    30,339 pass, 3 fail
  • @mschudders opened merge request.
  • Comment 11 months ago →
    🇧🇪Belgium Mschudders
  • Comment 11 months ago →
    🇧🇪Belgium kriboogh

    Tested on D9 and D10 works.

  • Status changed to Needs work 11 months ago
  • Comment 11 months ago →
    🇺🇸United States smustgrave

    MR should be updated for 11.x as it will have to land there first to be backported.

    But change seemed to cause some test failures so the fix may need to be tweaked.

    Also will need it's own test coverage.

  • Comment 11 months ago →
    🇧🇪Belgium Mschudders
  • First commit to issue fork.
  • Merge request !5320Resolve #3372217 "Media entity translations for 11x" → (Open) created by makbay
  • Pipeline finished with Failed
    7 months ago
    #46883
  • Comment 7 months ago →
    🇹🇷Turkey makbay

    This is a major one. I have updated the MR for 11.x.

  • Comment 4 months ago →
    🇪🇸Spain julio.raimondi Barcelona, Spain

    We have a requirement to have unpublished media in all active languages, ready to be published eventually, but the current functionality requires to have at least one media translation published as it is stated in the "This translation is published" checkbox: "You must publish at least one more translation to unpublish this one. "

    We created a patch (3372217-11-media-entity-translations-status-published-unpublished.patch) that has been tested in Drupal 10.2.2, PHP 8.1.26 and Mysql 5.7.42 successfully.

    Thanks for this solution that has allowed us to solve our issues, it was causing struggle and confusion among our content managers. We are glad this is being worked on, and without a doubt we consider it convenient for future releases.

  • Comment 4 months ago →
    🇪🇸Spain julio.raimondi Barcelona, Spain

    I Sorry, i made a mistake on the patch i uploaded on comment #11, i am uploading the right patch (3372217-12-media-entity-translations-status-published-unpublished.patch

  • First commit to issue fork.
  • Pipeline finished with Failed
    4 months ago
    #81167
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024