๐Ÿ‡ช๐Ÿ‡ธSpain @julio.raimondi

Barcelona, Spain
Account created on 23 October 2020, over 4 years ago
  • Senior developer at Digrupย  โ€ฆ
#

Recent comments

๐Ÿ‡ช๐Ÿ‡ธSpain julio.raimondi Barcelona, Spain

Just a diff patch against --branch 10.4.x to address this and other warnings, prior to new release

๐Ÿ‡ช๐Ÿ‡ธSpain julio.raimondi Barcelona, Spain

#71 worked correctly for us https://www.drupal.org/project/drupal/issues/2833734#comment-15844466 ๐Ÿ› Allow views attachment display to use its own pager options Needs work

๐Ÿ‡ช๐Ÿ‡ธSpain julio.raimondi Barcelona, Spain

โœ… Patch tested and verified on Drupal 10.4.7

This patch applies cleanly and resolves the issue where an attachment display in a View cannot render pager values when inheriting from the parent display.

๐Ÿ” Steps to reproduce and test:

Created a View with a paged display (e.g., page display with a pager).

Added an attachment display that references the paged display.

Enabled the Render pager option in the attachment display.

๐Ÿ”ง Result:

With the patch applied, the attachment correctly renders pager values when configured to inherit and render them.

Without the patch, the attachment display does not show pager output, even if render pager is enabled.

๐Ÿงช No regressions observed. Views behavior remains stable, and the patch only touches Attachment.php.

๐Ÿ“ฆ Patch is based on an updated fork where the original patch was implemented but not applying cleanly. Reformatted to Drupal standards using a/ and b/ paths.

โœ… Marking as Needs Review โ€” patch applies cleanly, fixes the issue, and is safe to test.

๐Ÿ‡ช๐Ÿ‡ธSpain julio.raimondi Barcelona, Spain

I Sorry, i made a mistake on the patch i uploaded on comment #11, i am uploading the right patch (3372217-12-media-entity-translations-status-published-unpublished.patch

๐Ÿ‡ช๐Ÿ‡ธSpain julio.raimondi Barcelona, Spain

We have a requirement to have unpublished media in all active languages, ready to be published eventually, but the current functionality requires to have at least one media translation published as it is stated in the "This translation is published" checkbox: "You must publish at least one more translation to unpublish this one. "

We created a patch (3372217-11-media-entity-translations-status-published-unpublished.patch) that has been tested in Drupal 10.2.2, PHP 8.1.26 and Mysql 5.7.42 successfully.

Thanks for this solution that has allowed us to solve our issues, it was causing struggle and confusion among our content managers. We are glad this is being worked on, and without a doubt we consider it convenient for future releases.

Production build 0.71.5 2024