Notice: Undefined index: #entity_type in ds_preprocess_ds_layout()

The patch don't want to apply:

wget https://www.drupal.org/files/issues/2023-01-07/ds-module-updated.patch →
patch -p1 < ds-module-updated.patch
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

After this experience I did the change/patch by hand. The problem is gone. So the solution works! Top!

I don't know why the patch won't apply. What I know is when opening the file in linux with nano I see garbage. Nano says "(Converted from Mac format) ". When I open the file in the hosting (cpanel environment) I can't read the content also. I don't know what's going on.

Thanks for making this patch so fast.
Marcel

i think there is an extra line in the patch file... try this one.

Patch #9 resoled the problem for us.

patch doesn't work. Error ds-undefined_index-3331674-9.patch:14: trailing whitespace

According to @alanin, the patch provided at #9 is not effective. However, I can confirm that the changes proposed in the merge request https://git.drupalcode.org/project/ds/-/merge_requests/13.diff are functioning as intended. As a result, I am marking this as RTBC.

      "drupal/ds": {
        "Notice: Undefined index: #entity_type in ds_preprocess_ds_layout()": "https://git.drupalcode.org/project/ds/-/merge_requests/13.diff"
      }

I can confirm as well that the changes proposed in the merge request https://git.drupalcode.org/project/ds/-/merge_requests/13.diff are functioning as intended.

@Rishi Kulshreshtha Thanks for the code snippet to put in composer.json until this gets committed!

Just made a patch file from the MR to simplify adding to the composer

swentel → closed merge request !13

committed and pushed, thanks

adding credits

Thanks for patch #15, we have tested it in drupal 9.5. And it works correctly.

This patch is already integrated for D10+ versions.

This patch complements the existing fix by addressing another undefined array key issue in the same function. While the existing patch fixes the entity copying section (line 630), this patch fixes the field copying loop (line 664) where fields like 'field_imatge_compartir' might be configured in DS but not present in the actual content array.

Tested with:
- Drupal 10.5.1
- PHP 8.2
- MySQL 8.0
- DS 3.30.0

The patch adds a check to ensure the field exists before accessing it, preventing PHP 8.2 warnings.