🇺🇸United States @rishi kulshreshtha

rishi kulshreshtha → changed the visibility of the branch issue/3317653-11.x to active.

rishi kulshreshtha → changed the visibility of the branch issue/3317653-11.x to hidden.

I just discovered that https://git.drupalcode.org/project/tablesorter/-/blob/8.x-1.x/tablesorte... already has the fix available!

rishi kulshreshtha → created an issue. See original summary → .

Based on the release notes and steps mentioned in #6, I followed them, and this resolved the issue for me:

drush search-api:server-disable <server_id>
drush search-api:server-enable <server_id>
drush solr-reload <server_id>
drush search-api:enable-all
drush sapi-i

None of the "One Click Demos" are working, Commerce Kickstart is also failing. https://simplytest.me/tugboat/progress/67366c1ad871e5f074240125/67366c1a...

Thank you for the tip, @lawxen. Resaving the DER field helped me out!

@drunken, when searching for values without the "&" symbol, I'm getting results, but including "&" isn't returning the expected one. I’m wondering if this issue is related to the database component or if it’s actually a problem with the Search API since I’m encountering it while using the Search API with Solr.

rishi kulshreshtha → created an issue.

Allows users with specific roles to see unpublished nodes of a certain type.

Provides an easy way to implement Schema.org structured data markup for enhanced search engine visibility.

Allows you to create a parent/child relationship between content types and use it to present content hierarchically.

Allows hierarchical referencing of entities, improving content display and structure management.

Proposed Categories

1. Site Structure
2. Content Display

Enables permission control over filters, improving security and content editing management.

Proposed Categories

1. Administration Tools
2. Security
3. Developer Tools

Controls access to entities, enhancing security and site structure flexibility.

Proposed Categories

1. Security

Provides profile management for users, enhancing engagement and user-related site structure.

Proposed Categories

1. User Engagement
2. Site Structure

Adds anchor link functionality to CKEditor, improving content editing and linking options.

Proposed Categories

1. Content Editing Experience

Adds support for tokens in content, enhancing content editing and developer functionality.

Proposed Categories

1. Content Editing Experience
2. Site Structure

Provides a UI for managing REST endpoints, supporting decoupled site architecture and developer tools.

Proposed Categories

1. Decoupled
2. Developer Tools
3. Integrations

Provides a layout builder for content, improving display and site structure management.

Proposed Categories

1. Content Display
2. Site Structure
3. Administration Tools

Protects forms from bots, improving security and user engagement.

Proposed Categories

1. Security
2. Developer Tools

Offers security hardening options, improving overall site protection and performance.

Proposed Categories

1. Security
2. Performance
3. Administration Tools

Provides backup and migration tools and data management.

Proposed Categories

1. Import and Export
2. Administration Tools

Enforces password policies for improved security and user management.

Proposed Categories

1. Security
2. Developer Tools

Optimizes CSS/JS aggregation for improved performance and developer control.

Proposed Categories

1. Performance
2. Developer Tools
3. Administration Tools

Adds a color selection field, improving content display and media management.

Proposed Categories

1. Content Editing Experience
2. Content Display

Improves site search functionality using Solr, enhancing performance and content display.

Proposed Categories

1. Site Search
2. Performance
3. Content Display

Enables CSV export of content, improving import/export and data management.

Proposed Categories

1. Import and Export
2. Developer Tools

Allows views to be referenced as fields, improving content display and structure.

Proposed Categories

1. Content Display
2. Site Structure

Adds the ability to manage link attributes, enhancing display and site structure.

Proposed Categories

1. Site Structure
2. Content Display
3. Developer Tools

Allows exporting data from views, improving data handling and reporting.

Proposed Categories

1. Import and Export
2. Content Display

Marks external links for security purposes and enhances integration with external sites.

Proposed Categories

1. Security
2. User Engagement

Proposed Category

1. Content Editing Experience

Provides tools for managing content migration, supporting import/export and developer functionality.

Proposed Categories

1. Import and Export
2. Developer Tools

Allows customization of menu link attributes, enhancing site structure and display.

Proposed Categories

1. Site Structure
2. Content Display
3. Developer Tools

Generates XML sitemaps for improved SEO and better content indexing by search engines.

Proposed Category

1. Search Engine Optimization (SEO)

Proposed Categories

1. Media
2. Content Display

Adds SVG image support, enhancing media options and visual content display.

Proposed Categories

1. Security
2. Integrations

Proposed Categories

1. Content Display
2. Media
3. User Engagement

Enables the display of media in a carousel format, improving media presentation and user engagement.

Proposed Categories

1. Import and Export
2. Developer Tools

Proposed Categories

1. Content Editing Experience
2. Administration Tools

Proposed Categories

1. Developer Tools
2. Administration Tools

Proposed Categories

1. Media
2. Content Editing Experience
3. Content Display

Automatically generates breadcrumbs based on content structure, improving navigation and SEO.

Proposed Categories

1. Search Engine Optimization (SEO)
2. Site Structure
3. Content Display

Allows adding custom classes to blocks, aiding in structure, display, and developer flexibility.

Proposed Categories

1. Site Structure
2. Content Display
3. Developer Tools

Integrates SMTP for secure email delivery, enhancing security and developer options.

Proposed Categories

1. Integrations
2. Security
3. Developer Tools

Proposed Categories

1. Search Engine Optimization (SEO)
2. Integrations
3. Performance

Integrates Google Tag Manager for managing tracking scripts, improving SEO and site performance.

Proposed Categories

1. Content Display
2. User Engagement
3. Performance

Proposed Categories

1. Content Editing Experience
2. User Engagement
3. Site Structure

This module provides an interactive date picker tool, improving the editing experience and user engagement.

As this module supports embedding entities within content, enhancing the editing interface and media usage.

Proposed Categories

1. Content Editing Experience
2. Media
3. Content Display

Looks good, how about?

Helps stop spam on Drupal sites by adding hidden fields to forms. Bots fill these fields by mistake, which alerts the system to block them, while real users aren't affected.

Patch #16 works flawlessly; an interdiff would've been helpful for recent fixes.

rishi kulshreshtha → created an issue.

@ressa, I'm experiencing the same issue you mentioned in comment #21. Were you able to get the highlight feature working with the setup described in Set up and configure a Multisite search with one core index → ?

Rishi Kulshreshtha → created an issue.

Encountered the same issue at checkout, the patch worked as expected.

Patch in comment #19 fixed the issue. Thanks.

Patch got applied cleanly, however this needs more work:

================================================================================
Username available AJAX check,  7.x-1.0+0-dev
Scanned on Thu, 03/07/2024 - 13:48

FILE: web/modules/contrib/username_check/src/Controller/DefaultController.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 37   Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 37   Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------
Check manually 83   Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 83   Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------
Fix now        123  Call to deprecated function valid_email_address().          
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::service('email.validator')->isValid().          
--------------------------------------------------------------------------------
Check manually 137  Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 137  Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------

FILE: web/modules/contrib/username_check/username_check.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Add core_version_requirement: ^8 || ^9 to designate that the
                    extension is compatible with Drupal 9. See                  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Rishi Kulshreshtha → created an issue.

I have attached a backport patch for the 1.x version.

I encountered the same issue after upgrading the core and contrib. However, switching from beta to dev fixed the issue for me.

`composer require 'drupal/commerce_price_rule:1.x-dev#33649e2'`

Suggestion given in comment #32 worked perfectly with Drupal 10.2.3. Thank you!

Please ignore the previous patch. The attached patch is the correct one, this includes the missing file core/lib/Drupal/Core/Entity/DependencyRemovalTrait.php.

I came across this issue while working on D10 upgrade for one of my sites. Please refer to the attached patch for anyone looking for a backport patch.

PS: Thanks to @TwoD for submitting the initial patch!

Using 2.0.x-dev, applied https://git.drupalcode.org/project/path_redirect_import/-/merge_requests... as a patch and using drupal/migrate_tools v6 but facing the exact same issue as reported at #29

================================================================================
Block Content Machine Name,  3.0.2
Scanned on Thu, 10/26/2023 - 15:22

FILE:
web/modules/contrib/block_content_machine_name/block_content_machine_name.info.y
ml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: web/modules/contrib/block_content_machine_name/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.   
--------------------------------------------------------------------------------

Rishi Kulshreshtha → created an issue.

This is now ready for review. Feel free to use this as patch https://git.drupalcode.org/project/field_default_token/-/merge_requests/...

Rishi Kulshreshtha → made their first commit to this issue’s fork.

A migration document from wysiwyg_template to https://www.drupal.org/project/ckeditor5_template → would be very helpful. Until we have that in place, the only option left is to use the patch attached at #15. The patch looks good except for one thing:

================================================================================
Wysiwyg Template Plugin
Scanned on Wed, 10/11/2023 - 09:15

FILE:
web/modules/contrib/wysiwyg_template/modules/wysiwyg_template_core/wysiwyg_templ
ate_core.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 is not        
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Short and sweet, looks good to be released.

Patch provided to #11 got applied cleanly.

This is now back to review.

Patch provided at #8 was applied, but compatibility errors persist. Marking as needs work.

================================================================================
Commerce FedEx, --
Scanned on Mon, 10/09/2023 - 09:48

FILE: web/modules/contrib/commerce_fedex/tests/src/Kernel/FedExRateTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 52   Call to deprecated method prophesize() of class             
                    PHPUnit\Framework\TestCase:                                 
                    https://github.com/sebastianbergmann/phpunit/issues/4141    
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/commerce_fedex/modules/dry_ice/commerce_fedex_dry_ice.info.y
ml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/commerce_fedex/modules/dangerous/commerce_fedex_dangerous.in
fo.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

This issue is good to close, as the only remaining issue was committed by the author.

This is now ready for review, someone looking for a patch can use https://git.drupalcode.org/project/commerce_transaction/-/merge_requests...

FILE: web/modules/contrib/commerce_transaction/commerce_transaction.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Rishi Kulshreshtha → created an issue.

Back to Needs Review, for someone looking to apply this as a patch can use https://git.drupalcode.org/project/direct_checkout_by_url/-/merge_reques...

This needs work as assertEqual() will be removed in Drupal 10.

FILE:
web/modules/contrib/direct_checkout_by_url/tests/src/Functional/RedirectTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 128  Call to deprecated method assertEqual() of class            
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and
                    is removed from drupal:10.0.0. Use $this->assertEquals()    
                    instead.                                                    
--------------------------------------------------------------------------------

Sweet and simple, works as expected!

Rishi Kulshreshtha → made their first commit to this issue’s fork.

Rishi Kulshreshtha → created an issue.

@Ammar Qala, thanks for your efforts but there's no need for a patch when someone can use https://git.drupalcode.org/project/login_destination/-/merge_requests/13...

+1 to the patch, works as expected.

As far as I can observe, the problem persists with the radio button's widget.

1. To address the issue, we need to create two fields: one list text field as the selector and one taxonomy term reference field as the target.
2. The target field should be made required based on a value selected from the selector field.
3. Although the target field shows the required asterisk, it fails to perform validation as expected.

I have included a brief screencast demonstrating this issue.

#9 looks good, and got applied cleanly to 4.x-dev as well. Marking this as RTBC.

@roderik, thank you for your efforts on this module and for creating this ticket.

It feels to me like new users will have more of a handle of what all these options do, if they are split by incoming vs outoing message, rather than security vs. miscellaneous options.

That's an excellent suggestion!

We might want to build in auto-configuration of various settings by reading the IdP's metadata XML. I'm hesitant to change defaults until then (because I might see things differently after that).

I agree with that approach. In general, we can include an import field that accepts XML, allowing us to process the IdP's metadata and populate the admin/config/people/saml form automatically.