Patch in comment #19 fixed the issue. Thanks.
Patch got applied cleanly, however this needs more work:
================================================================================
Username available AJAX check, 7.x-1.0+0-dev
Scanned on Thu, 03/07/2024 - 13:48
FILE: web/modules/contrib/username_check/src/Controller/DefaultController.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 37 Call to deprecated method checkPlain() of class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use
the @link theme_render #plain_text @endlink key when
constructing a render array that contains plain text in
order to use the renderer's auto-escaping feature. If
neither of these are possible,
\Drupal\Component\Utility\Html::escape() can be used in
places where explicit escaping is needed.
--------------------------------------------------------------------------------
Check manually 37 Call to method checkPlain() of deprecated class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Use the appropriate
--------------------------------------------------------------------------------
Check manually 83 Call to deprecated method checkPlain() of class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use
the @link theme_render #plain_text @endlink key when
constructing a render array that contains plain text in
order to use the renderer's auto-escaping feature. If
neither of these are possible,
\Drupal\Component\Utility\Html::escape() can be used in
places where explicit escaping is needed.
--------------------------------------------------------------------------------
Check manually 83 Call to method checkPlain() of deprecated class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Use the appropriate
--------------------------------------------------------------------------------
Fix now 123 Call to deprecated function valid_email_address().
Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
Use Drupal::service('email.validator')->isValid().
--------------------------------------------------------------------------------
Check manually 137 Call to deprecated method checkPlain() of class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use
the @link theme_render #plain_text @endlink key when
constructing a render array that contains plain text in
order to use the renderer's auto-escaping feature. If
neither of these are possible,
\Drupal\Component\Utility\Html::escape() can be used in
places where explicit escaping is needed.
--------------------------------------------------------------------------------
Check manually 137 Call to method checkPlain() of deprecated class
Drupal\Component\Utility\SafeMarkup: Will be removed before
Drupal 9.0.0. Use the appropriate
--------------------------------------------------------------------------------
FILE: web/modules/contrib/username_check/username_check.info.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Add core_version_requirement: ^8 || ^9 to designate that the
extension is compatible with Drupal 9. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
Rishi Kulshreshtha → created an issue.
I have attached a backport patch for the 1.x version.
I encountered the same issue after upgrading the core and contrib. However, switching from beta to dev fixed the issue for me.
`composer require 'drupal/commerce_price_rule:1.x-dev#33649e2'`
Suggestion given in comment #32 worked perfectly with Drupal 10.2.3. Thank you!
Please ignore the previous patch. The attached patch is the correct one, this includes the missing file core/lib/Drupal/Core/Entity/DependencyRemovalTrait.php.
I came across this issue while working on D10 upgrade for one of my sites. Please refer to the attached patch for anyone looking for a backport patch.
PS: Thanks to @TwoD for submitting the initial patch!
Using 2.0.x-dev, applied https://git.drupalcode.org/project/path_redirect_import/-/merge_requests... as a patch and using drupal/migrate_tools v6 but facing the exact same issue as reported at #29
================================================================================
Block Content Machine Name, 3.0.2
Scanned on Thu, 10/26/2023 - 15:22
FILE:
web/modules/contrib/block_content_machine_name/block_content_machine_name.info.y
ml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
FILE: web/modules/contrib/block_content_machine_name/composer.json
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 The drupal/core requirement is not compatible with the next
major version of Drupal. Either remove it or update it to be
compatible. See
https://drupal.org/node/2514612#s-drupal-9-compatibility.
--------------------------------------------------------------------------------
Rishi Kulshreshtha → created an issue.
This is now ready for review. Feel free to use this as patch https://git.drupalcode.org/project/field_default_token/-/merge_requests/...
Rishi Kulshreshtha → made their first commit to this issue’s fork.
A migration document from wysiwyg_template to https://www.drupal.org/project/ckeditor5_template → would be very helpful. Until we have that in place, the only option left is to use the patch attached at #15. The patch looks good except for one thing:
================================================================================
Wysiwyg Template Plugin
Scanned on Wed, 10/11/2023 - 09:15
FILE:
web/modules/contrib/wysiwyg_template/modules/wysiwyg_template_core/wysiwyg_templ
ate_core.info.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8.8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
Short and sweet, looks good to be released.
Patch provided to #11 got applied cleanly.
This is now back to review.
Patch provided at #8 was applied, but compatibility errors persist. Marking as needs work.
================================================================================
Commerce FedEx, --
Scanned on Mon, 10/09/2023 - 09:48
FILE: web/modules/contrib/commerce_fedex/tests/src/Kernel/FedExRateTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 52 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
FILE:
web/modules/contrib/commerce_fedex/modules/dry_ice/commerce_fedex_dry_ice.info.y
ml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
FILE:
web/modules/contrib/commerce_fedex/modules/dangerous/commerce_fedex_dangerous.in
fo.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
This issue is good to close, as the only remaining issue was committed by the author.
This is now ready for review, someone looking for a patch can use https://git.drupalcode.org/project/commerce_transaction/-/merge_requests...
FILE: web/modules/contrib/commerce_transaction/commerce_transaction.info.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------Rishi Kulshreshtha → created an issue.
Back to Needs Review, for someone looking to apply this as a patch can use https://git.drupalcode.org/project/direct_checkout_by_url/-/merge_reques...
This needs work as assertEqual() will be removed in Drupal 10.
FILE:
web/modules/contrib/direct_checkout_by_url/tests/src/Functional/RedirectTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 128 Call to deprecated method assertEqual() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and
is removed from drupal:10.0.0. Use $this->assertEquals()
instead.
--------------------------------------------------------------------------------
Sweet and simple, works as expected!
Rishi Kulshreshtha → made their first commit to this issue’s fork.
Rishi Kulshreshtha → created an issue.
@Ammar Qala, thanks for your efforts but there's no need for a patch when someone can use https://git.drupalcode.org/project/login_destination/-/merge_requests/13...
+1 to the patch, works as expected.
As far as I can observe, the problem persists with the radio button's widget.
- To address the issue, we need to create two fields: one list text field as the selector and one taxonomy term reference field as the target.
- The target field should be made required based on a value selected from the selector field.
- Although the target field shows the required asterisk, it fails to perform validation as expected.
I have included a brief screencast demonstrating this issue.
#9 looks good, and got applied cleanly to 4.x-dev as well. Marking this as RTBC.
@roderik, thank you for your efforts on this module and for creating this ticket.
It feels to me like new users will have more of a handle of what all these options do, if they are split by incoming vs outoing message, rather than security vs. miscellaneous options.
That's an excellent suggestion!
We might want to build in auto-configuration of various settings by reading the IdP's metadata XML. I'm hesitant to change defaults until then (because I might see things differently after that).
I agree with that approach. In general, we can include an import field that accepts XML, allowing us to process the IdP's metadata and populate the admin/config/people/saml form automatically.
@trickfun, you can use https://git.drupalcode.org/project/google_tag/-/merge_requests/6.diff as the location of the patch in your composer.json
I have replaced the getLabel() method with the appropriate label() method, ensuring the correct invocation of the method for deleting the destination.
Rishi Kulshreshtha → made their first commit to this issue’s fork.
As mentioned by @TrevorBradley on #3, locking Drupal to composer require drupal/core-recommended:10.0.9 works without any issues.
@tikaszvince, I'll try your solution soon.
The solution provided at #6 works for those who don't need translation of the values.
Given the specific requirement to hide elements containing the word "Overview," it seems that CSS may not be the most suitable solution. Instead, I successfully accomplished this task using jQuery:
(function ($, Drupal) {
Drupal.behaviors.hideMenuOverview = {
attach: function (context, settings) {
// CSS selector for the menu item.
const menuSelector = '.menu-item__menu_link_content\\:7c45b7f1-64a6-4700-86f1-9216ee8d78ee';
$(once('hide-menu-item-overview', menuSelector, context)).each(function () {
// Find child element(s) within the menu item that contain "Overview"
// text.
const childElement = $(this).find('a:contains("Overview")');
// Hide the child element(s)
childElement.hide();
});
}
};
})(jQuery, Drupal);
@Johan den Hollander, thank you for recommending the implementation of all the patches. simplesamlphp_auth is making progress, but unfortunately, I am still unable to log in. I'm encountering an error message stating, "Oops! An Error Occurred The server returned a "500 Internal Server Error". Something is broken. Please let us know what you were doing when this error occurred. We will fix it as soon as possible. Sorry for any inconvenience caused."
Here are the entries, that I have related to simplesamlphp in my composer.json file.
"require": {
"drupal/simplesamlphp_auth": "^4",
"simplesamlphp/saml2": "5.0.0-alpha.6",
"simplesamlphp/simplesamlphp": "dev-master#8c6ee7dd6a6",
"simplesamlphp/simplesamlphp-module-adfs": "dev-master@dev",
"simplesamlphp/simplesamlphp-module-logpeek": "^1.0",
"simplesamlphp/simplesamlphp-module-rfs": "^1.0",
"simplesamlphp/simplesamlphp-module-yubikey": "dev-master#d7c939d",
}
"patches": {
"drupal/simplesamlphp_auth": {
"4.0.0-alpha1 release compatible with D10/Symfony6 - 3349278_documentation_19": "https://www.drupal.org/files/issues/2023-04-05/3349278_documentation_19.patch",
"4.0.0-alpha1 release compatible with D10/Symfony6 - 3349278-d10-compatibility_14": "https://www.drupal.org/files/issues/2023-04-04/3349278-d10-compatibility_14.patch",
"4.0.0-alpha1 release compatible with D10/Symfony6 - RedirectResponse fix for D10 compatibility": "https://www.drupal.org/files/issues/2023-06-17/simplesamlphp_auth_d10_redirect.patch"
},
"simplesamlphp/saml2": {
"4.0.0-alpha1 release compatible with D10/Symfony6": "https://www.drupal.org/files/issues/2023-06-17/simplesamlphp_saml2_d10_container_singleton.patch"
}
}
Unfortunately, the patch provided in comment #39 does not resolve the issue for me, even though I diligently followed the instructions mentioned in comment #42 and comment #43.
These are the entries related to simplesamlphp in my composer.json file:
"drupal/simplesamlphp_auth": "^4",
"simplesamlphp/saml2": "5.0.0-alpha.6",
"simplesamlphp/simplesamlphp": "dev-master#8c6ee7dd6a6",
"simplesamlphp/simplesamlphp-module-adfs": "dev-master@dev",
"simplesamlphp/simplesamlphp-module-logpeek": "^1.0",
I am experiencing the same error as mentioned in issue #31. At first, I thought that locking the dependent projects by using the following Composer command would resolve the issue:
composer require simplesamlphp/simplesamlphp:dev-master#7b69799 simplesamlphp/simplesamlphp-module-adfs:dev-master#62f4d63 simplesamlphp/saml2:^4.6
However, unfortunately, Composer is not cooperating, and the problem persists. It is clear that this situation requires further attention and effort to resolve.
The arrow function () => { ... } used in the code was replaced with a regular function function() { ... }. This change was made to ensure compatibility with older versions of JavaScript or libraries that may not support arrow functions.
The element selection within the once function was updated. Previously, $(once("flexslider", #${id}, context)) was used to select elements, but it was changed to $(this) to refer to the current element being processed. This change allows for better clarity and ensures that the correct elements are targeted for manipulation.
This is now ready to be tested!
https://git.drupalcode.org/project/flexslider/-/merge_requests/4.diff
This isn't working, needs work!
Rishi Kulshreshtha → created an issue.
The code implementation of this module appears excellent. The only necessary adjustment is updating the core_version_requirement to also accommodate d10. Other than that, it is flawless.
Further improvement is required as I can still see errors even after implementing the most recent patch.
================================================================================
Field Collection, --
Scanned on Mon, 05/29/2023 - 13:36
FILE: modules/contrib/field_collection/src/Entity/FieldCollectionItem.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 294 Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
--------------------------------------------------------------------------------
FILE:
modules/contrib/field_collection/tests/src/FunctionalJavascript/FieldCollectionA
jaxTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 15 Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
https://www.drupal.org/node/3083055, which includes
recommendations on which theme to use.
--------------------------------------------------------------------------------
FILE: modules/contrib/field_collection/field_collection.info.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
The change made at https://git.drupalcode.org/project/eck/-/merge_requests/21.diff appear to be satisfactory, as the patch was successfully applied without any conflicts using drupal-lenient, and ECK now functions smoothly with Drupal 10 without encountering any problems. RTBC +1
"patches": {
"drupal/eck": {
"#3287130": "https://git.drupalcode.org/project/eck/-/merge_requests/21.diff"
}
}
According to @alanin, the patch provided at #9 is not effective. However, I can confirm that the changes proposed in the merge request https://git.drupalcode.org/project/ds/-/merge_requests/13.diff are functioning as intended. As a result, I am marking this as RTBC.
"drupal/ds": {
"Notice: Undefined index: #entity_type in ds_preprocess_ds_layout()": "https://git.drupalcode.org/project/ds/-/merge_requests/13.diff"
}
Rishi Kulshreshtha → created an issue.
@AaronBauman, as per the instructions in this comment on the
Retrieve attachment content →
, I have added a subquery as a field under pullQueryAlter. The other fields added under this function are working fine and I can see their values while debugging and they work when added under pullPreSave. However, I am unable to see the subquery field or its value under pullPreSave. What steps should I take in order to retrieve the value of the relationship that was added under pullQueryAlter from Salesforce to Drupal?
An example of the added subquery is:
case 'my_mapping':
// Adds a field.
$query->fields['Drupal_ID__c'] = 'Drupal_ID__c';
// Adds a subquery.
$query->fields[] = 'SELECT Contact__r.Name, Contact__r.Email, Contact__r.Alternate_e_mail__c, Role__c FROM Project_Roles__r';
break;
@pingevt, that's correct. Another approach someone can do is via code as mentioned by @AaronBauman earlier.
Something like this, by subscribing to the salesforce.pull_presave EventSubscriber & then the following should help:
$entity = $event->getEntity();
$sfBody = $event->getMappedObject()->getSalesforceRecord()->field('Body__c');
$sfBody = [
'value' => $sfBody,
'format' => 'full_html',
];
$entity->set('body', $sfBody);
@pingevt, I was able to resolve the issue by using Drupal Constant. Sharing the snippet from my existing salesforce_mapping.salesforce_mapping.mapping_id.yml
-
drupal_field_type: properties
drupal_field_value: body.value
direction: sf_drupal
salesforce_field: Body__c
id: 7
description: ''
-
drupal_field_type: DrupalConstant
drupal_field_value: body.format
direction: sf_drupal
id: 8
drupal_constant: basic_html
By default, the module gave me drupal_field_value: body, which I updated to drupal_field_value: body.format and it worked as expected.
MR got applied cleanly, but this needs work!
================================================================================
Mailchimp, --
Scanned on Thu, 01/26/2023 - 01:32
FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Form/MailchimpCampa
ignForm.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 139 The 'mailchimp_campaign/campaign-form' library is not
defined because the defining extension is not installed.
Cannot decide if it is deprecated or not.
--------------------------------------------------------------------------------
FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Entity/MailchimpCam
paignViewBuilder.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 50 The 'mailchimp_campaign/campaign-view' library is not
defined because the defining extension is not installed.
Cannot decide if it is deprecated or not.
--------------------------------------------------------------------------------
FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Controller/Mailchim
pCampaignController.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 298 The 'mailchimp_campaign/google-jsapi' library is not defined
because the defining extension is not installed. Cannot
decide if it is deprecated or not.
--------------------------------------------------------------------------------
Check manually 299 The 'mailchimp_campaign/campaign-stats' library is not
defined because the defining extension is not installed.
Cannot decide if it is deprecated or not.
--------------------------------------------------------------------------------
After applying the required fixes:
================================================================================
Block Visibility Groups, --
Scanned on Thu, 01/26/2023 - 01:24
No known issues found.
This needs work, still a couple of complaints as per D10 compatibility!
================================================================================
Block Visibility Groups, --
Scanned on Thu, 01/26/2023 - 01:19
FILE:
web/modules/contrib/block_visibility_groups/tests/src/Functional/BlockVisibility
GroupsUiTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 169 Call to deprecated method assertEqual() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and
is removed from drupal:10.0.0. Use $this->assertEquals()
instead.
--------------------------------------------------------------------------------
Check manually 258 Call to deprecated method assertEqual() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and
is removed from drupal:10.0.0. Use $this->assertEquals()
instead.
--------------------------------------------------------------------------------
Check manually 261 Call to deprecated method assertEqual() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and
is removed from drupal:10.0.0. Use $this->assertEquals()
instead.
--------------------------------------------------------------------------------
================================================================================
Feeds Paragraphs, --
Scanned on Thu, 01/26/2023 - 12:44
No known issues found.
To test the MR on D10, one can use composer-drupal-lenient or update your composer.json's repositories with the following:
"repositories": [
{
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/feeds_para_mapper"
]
},
{
"type": "git",
"url": "https://git.drupalcode.org/issue/feeds_para_mapper-3336643.git"
}
],
After that execute, composer require 'drupal/feeds_para_mapper:dev-3336643-drupal-10-compatibility'. Ensure that the minimum-stability in your composer.json is set to dev.
I want co-maintainership and I promise to abide by the conditions of the Open Ownership Pledge as described. I have provided patches for one of the corresponding issues.
Rishi Kulshreshtha → created an issue.
@Giuseppe87, feel free to try the steps from this comment: #7 📌 Automated Drupal 9 compatibility fixes Needs review
I want co-maintainership and I promise to abide by the conditions of the Open Ownership Pledge as described. I have provided patches for one of the corresponding issues.
@kazah & @zapaaron, feel free to try the steps from this comment: #7 📌 Automated Drupal 9 compatibility fixes Needs review
I want co-maintainership and I promise to abide by the conditions of the Open Ownership Pledge as described. I have provided patches for one of the corresponding issues.
I want co-maintainership and I promise to abide by the conditions of the Open Ownership Pledge as described. I have provided patches for one of the corresponding issues.
To test the MR, kindly update your composer.json's repositories with the following:
"repositories": [
{
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/feeds_para_mapper"
]
},
{
"type": "git",
"url": "https://git.drupalcode.org/issue/feeds_para_mapper-3147462.git"
}
],
After that execute, composer require 'drupal/feeds_para_mapper:dev-3147462-automated-drupal-9'. Ensure that the minimum-stability in your composer.json is set to dev.
================================================================================
Feeds Paragraphs, --
Scanned on Thu, 01/26/2023 - 11:44
FILE: web/modules/contrib/feeds_para_mapper/feeds_para_mapper.info.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Add core_version_requirement: ^8 || ^9 to designate that the
extension is compatible with Drupal 9. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
FILE: web/modules/contrib/feeds_para_mapper/composer.json
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 The drupal/core requirement is not compatible with the next
major version of Drupal. Either remove it or update it to be
compatible. See
https://drupal.org/node/2514612#s-drupal-9-compatibility.
--------------------------------------------------------------------------------
This still needs work for D9!
@Giuseppe87, with D9 you've to use Drupal's Lenient Composer Endpoint → . The one on D10 can use composer-drupal-lenient