Contrib.social

Automated Drupal 9 compatibility fixes

Open on Drupal.org →
Created on 23 May 2020, almost 5 years ago
Updated 7 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches →

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot →
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇺🇸United States rishi kulshreshtha

    Patch got applied cleanly, however this needs more work:

    ================================================================================
Username available AJAX check,  7.x-1.0+0-dev
Scanned on Thu, 03/07/2024 - 13:48

FILE: web/modules/contrib/username_check/src/Controller/DefaultController.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 37   Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 37   Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------
Check manually 83   Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 83   Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------
Fix now        123  Call to deprecated function valid_email_address().          
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::service('email.validator')->isValid().          
--------------------------------------------------------------------------------
Check manually 137  Call to deprecated method checkPlain() of class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Rely on Twig's auto-escaping feature, or use  
                    the @link theme_render #plain_text @endlink key when        
                    constructing a render array that contains plain text in     
                    order to use the renderer's auto-escaping feature. If       
                    neither of these are possible,                              
                    \Drupal\Component\Utility\Html::escape() can be used in     
                    places where explicit escaping is needed.                   
--------------------------------------------------------------------------------
Check manually 137  Call to method checkPlain() of deprecated class             
                    Drupal\Component\Utility\SafeMarkup: Will be removed before 
                    Drupal 9.0.0. Use the appropriate                           
--------------------------------------------------------------------------------

FILE: web/modules/contrib/username_check/username_check.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Add core_version_requirement: ^8 || ^9 to designate that the
                    extension is compatible with Drupal 9. See                  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------
  • Merge request !1Make module D9 compatible & misc code cleanup → (Open) created by rishi kulshreshtha
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States rishi kulshreshtha
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024