Fix Deprecated function: Creation of dynamic property Drupal\yoast_seo\YoastSeoManager::$yoast_seo_field_manager is deprecated

I have reviewed the MR and i can see no Drupal alert is coming now.

Patch cleans up Drupal deprecated warning in PHP 8.2.

@yogesh_kambari Please, when doing code reviews also look at the actual code being written. Just testing if the code applies is not sufficient to set an issue to RTBC.

amatzies → closed merge request !21

I couldn't push any changes into existing MR so here is a patch with a fix of YoastSeoFieldManager service usage.

Using composer to install I get an error:

- Installing drupal/yoast_seo (1.8.0): Extracting archive
- Applying patches for drupal/yoast_seo
https://www.drupal.org/files/issues/2023-07-28/yoast_seo-3362165-depreca... → (Deprecated function: Creation of dynamic property Drupal\yoast_seo\YoastSeoManager::$yoast_seo_field_manager is deprecated in Drupal\yoast_seo\YoastSeoManager->__construct() (line 44 of modules/contrib/yoast_seo/src/YoastSeoManager.php).)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-07-28/yoast_seo-3362165-depreca... →

@SocialNicheGuru Patches are for the dev release. Not for the latest stable release. If needed you need to rebase the patch manually in order to resolve the conflicts on that release and export it into a new patch file to use.

The dev and the current release have the same release date Dec 16 2022.
I assumed they are the same. I guess not.

Updated the merge request to correct YoastSeoManager's definition of the Yoast SEO Field Manager, and to inject additional services per Drupal coding standards → .

The changes in the MR make things way cleaner, but they seem out of scope for this issue. I'm attaching a patch with the only change that I think is required to get rid of the warning. It would be good to create a separate issue to clean up service injection.

Patch in comment #19 fixed the issue. Thanks.

Noting that this issue is already fixed in version 2 of this module. However this could still be merged into version 1.x.