Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 19 January 2024, 10 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States rishi kulshreshtha

    Short and sweet, looks good to be released.

  • Comment about 1 year ago →
    🇺🇸United States chucksimply

    #2 didn't work for me on alpha1. Attached patch does.

  • Comment about 1 year ago →
    🇫🇷France laurent.lannoy

    Thank you @chucksimply for the "alpha1" version of the patch, the leaflet_mapbox.info.yml file has been successfully updated:

    core_version_requirement: ^8.7.7 || ^9 || ^10

    ... but when I want to update the core version from 9.5.11 to 10.1.6, I got the following error message as the row had not been updated:

    Your requirements could not be resolved to an installable set of packages.

      Problem 1
    - Root composer.json requires drupal/leaflet_mapbox ^1.0@alpha -> satisfiable by drupal/leaflet_mapbox[1.0.0-alpha1].
    - drupal/leaflet_mapbox 1.0.0-alpha1 requires drupal/core ^8.7.7 || ^9 -> found drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (^10).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
  • Comment about 1 year ago →
    🇺🇸United States squiggy

    To use a module that doesn't have a Drupal 10 release, you can add <a href="https://github.com/mglaman/composer-drupal-lenient ">mglaman/composer-drupal-lenient</a> as a dependency to your composer.json, which will allow a patched version of the module for Drupal 10.

  • Comment about 1 year ago →
    🇫🇷France laurent.lannoy

    Thanks Squiggy.

    This was my first install of an unsupported module.

    I couldn't update, so I uninstalled leaflet_mapbox on D9 first, then updated the website to D10, then reinstalled leaflet_mapbox with the help of mglaman/composer-drupal-lenient and the patch #6.

    Everything seems OK under Drupal 10 and I can visualize my map with my map defined in Mapbox and using the leaflet_mapbox module. 👍

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇵🇭Philippines mjgruta

    I'm getting the error below when running composer install.

    In RemoteFilesystem.php line 108:
                                                                                                                                                                                                 
  [TypeError]                                                                                                                                                                                    
  Composer\Util\RemoteFilesystem::copy(): Argument #1 ($originUrl) must be of type string, null given, called in /home/ide/project/vendor/cweagans/composer-patches/src/Patches.php on line 388

    Using 1.x-dev and cweagans/composer-patches:1.7.3
    composer require "drupal/leaflet_mapbox:1.x-dev@dev"
    Added this module in drupal-lenient in composer.json and globally.

  • Merge request !1#3288279 Applied patch to set version number → (Open) created by mjgruta
  • First commit to issue fork.
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇺🇸United States chucksimply

    Where are we at with this latest merge request? Can we get a new D10 release?!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024