Drupal 10 Compatibility

Basic compatibility patch

Here is a patch with the stuff from upgrade status.

still seeing:
Call to deprecated method prophesize() of class Drupal\Tests\commerce_fedex\Kernel\FedExRateTest: https://github.com/sebastianbergmann/phpunit/issues/4141

because of a bug with upgrade status I believe.

In D10 using #4 📌 Drupal 10 Compatibility Needs review patch, the below error occurs when we checkout the order and proceed with the payment.

TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given, called in /app/web/modules/contrib/commerce_fedex/src/Packer/CommerceFedExPacker.php on line 138 in Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (line 89 of core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php).

We need to change the symphony syntax change in dispatch.

Sorry, for the empty above #5 📌 Drupal 10 Compatibility Needs review patch attached one is the right patch.

This patch wasn't applying for me. Also I had an issue with prophecy not actually being installed, so I think it might need to be in the composer require-dev just to make sure.

I haven't tested this through thoroughly yet.

Sorry, one more event dispatch fix that was part of another patch but should be included in this one.

Patch provided at #8 was applied, but compatibility errors persist. Marking as needs work.

================================================================================
Commerce FedEx, --
Scanned on Mon, 10/09/2023 - 09:48

FILE: web/modules/contrib/commerce_fedex/tests/src/Kernel/FedExRateTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 52   Call to deprecated method prophesize() of class             
                    PHPUnit\Framework\TestCase:                                 
                    https://github.com/sebastianbergmann/phpunit/issues/4141    
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/commerce_fedex/modules/dry_ice/commerce_fedex_dry_ice.info.y
ml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/commerce_fedex/modules/dangerous/commerce_fedex_dangerous.in
fo.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

This is now back to review.

The failed tests related to this issue https://github.com/NicholasCreativeMedia/FedExPHP/issues/4

I can't really tell what patch version was actually committed, but, regardless almost everybody at least deserves issue credit for their work, not just the last person that submitted a patch.

TomTech → closed merge request !5

Automatically closed - issue fixed for 2 weeks with no activity.