Account created on 13 October 2018, over 5 years ago
#

Merge Requests

More

Recent comments

I found this to be more dependable:

    // Join the order table and skip all items from orders that are carts.
    $query->leftjoin('commerce_order', 'o', 'o.order_id = li.order_id');
    $query->addField('o', 'status', 'o_status');
    $query->condition('o.status', 'checkout_checkout', 'NOT IN');
    $query->condition('o.status', 'checkout_shipping', 'NOT IN');
    $query->condition('o.status', 'checkout_review', 'NOT IN');
    $query->condition('o.status', 'cart', 'NOT IN');

So basically, the issue was here setting the single group id as an $id_field_alias, was just returning one result, and preventing the array from being built for each result - since there is only one group.

Not sure the most dependable way to get the group_item ids off the view, and also, I think this would require the view to have a group item relationship.

Ok, good start.

Now we just need to decide what rows and style options we need.

No clue why Stan is complaining about this:

 ------ ------------------------------------------------------------------- 
  Line   commerce_vado.install                                              
 ------ ------------------------------------------------------------------- 
  67     Inner named functions are not supported by PHPStan. Consider       
         refactoring to an anonymous function, class method, or a           
         top-level-defined function. See issue #165                         
         (https://github.com/phpstan/phpstan/issues/165) for more details.  
 ------ ------------------------------------------------------------------- 

We might just have to add that to the baseline, as it's just an update hook.

Here is the JS warnings:

/builds/project/commerce_ajax_atc/web/modules/custom/commerce_ajax_atc/js/commerce_ajax_atc.js
  1:2   warning  Unexpected unnamed function                                                                                                                                                                                                                                                 func-names
  3:5   warning  Unexpected unnamed method 'attach'                                                                                                                                                                                                                                          func-names
  3:5   error    Expected method shorthand                                                                                                                                                                                                                                                   object-shorthand
  3:23  warning  'context' is defined but never used                                                                                                                                                                                                                                         no-unused-vars
  3:32  warning  'settings' is defined but never used                                                                                                                                                                                                                                        no-unused-vars
  4:7   error    Unexpected use of 'parent'                                                                                                                                                                                                                                                  no-restricted-globals
  4:38  error    Replace `width:drupalSettings.commerce_ajax_atc.colorbox.width·,·height:drupalSettings.commerce_ajax_atc.colorbox.height` with `⏎········width:·drupalSettings.commerce_ajax_atc.colorbox.width,⏎········height:·drupalSettings.commerce_ajax_atc.colorbox.height,⏎······`  prettier/prettier
  5:6   error    Insert `,`                                                                                                                                                                                                                                                                  prettier/prettier
  7:53  warning  Unexpected unnamed function                                                                                                                                                                                                                                                 func-names
  7:63  warning  'ajax' is defined but never used                                                                                                                                                                                                                                            no-unused-vars
  7:69  warning  'response' is defined but never used                                                                                                                                                                                                                                        no-unused-vars
  8:23  error    Insert `;`                                                                                                                                                                                                                                                                  prettier/prettier
βœ– 12 problems (5 errors, 7 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

tonytheferg β†’ changed the visibility of the branch 3422161- to hidden.

Yeah, the baseline should be generated based on the level we are running which is NOT 7. :)
That txt file is for level 7. The command to generate the baseline for level 1 is:

../../../../vendor/bin/phpstan analyse --level 1   --configuration phpsta
n.neon   src/ tests/ --generate-baseline

stepping back to vendor from the commerce_vado directory.

Added the baseline at level one after removing ignore for dependency injection.

Seems good to me for now. See if the pipeline agrees.

I ran the command for the baseline:

../../../../vendor/bin/phpstan analyse --level 7   --configuration phpsta
n.neon   src/ tests/ --generate-baseline

and got:
[OK] Baseline generated with 327 errors.

Some of which were fixed. Need to know more about the how and what there...

The only thing left hiding would be this:

------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 

Couldn't really find examples in Core of them using DI for Entity Query, so maybe we can leave that one be.

Basically, the only stuff that got overlooked in ignoring errors are these dependency injection issues.

------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/EventSubscriber/VadoEventSubscriber.php                           
 ------ ---------------------------------------------------------------------- 
  195    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php                                       
 ------ --------------------------------------------------------------------------------------------------                                                   
  175    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  400    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
 ------ -------------------------------------------------------------------------------------------------- 

This works, but I'm not sure on the field name. We have include_parent which is about the parent variation being included in the discount, so exclude_parent sounds like it would just be the opposite of that, but actually it's to exclude the variation.

I'd prefer not having to change include_parent field name, so maybe we need to name this field exclude_parent_variation?

Also I'll need to account for this in the order processor, and add test coverage, which will be easy.

Don't mean to be combative by reopening. I don't think it's a duplicate tho.

I mean if it's something that won't get added, I can just add the condition to my custom module. No worries.

But I have to imagine this limiting UX is a pain point for some.

Those issues don't address the scenario we are addressing in this issue.

For example, we have promotions that runs on 5 or more or any of 30+ skus.
The autocomplete widget is insufficient for that.

The patch provides the following implementation:

  • When the setting is off (the desired setting for the default form display which governs the edit form), no calculation happens, and no methods are shown until the "Recalculate" button until clicked.
  • When the setting is on (the desired setting for the checkout form display) calculation happens automatically.

Also for Lukas Von Blarer's comment in #21,

I have opened another issue for that, that references this issue.
πŸ“Œ Improve shipping method behavior on admin shipment form Active

This patch simply omits the check for draft:
$shipment->getState()->value != 'draft' &&

I don't think we want to check for drafts. editing the shipment for the first time pulls up the methods, which we want to be governed by the form display setting, not the shipment state.

Here's what's left:

 ------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/EventSubscriber/VadoEventSubscriber.php                           
 ------ ---------------------------------------------------------------------- 
  195    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/VadoGroupForm.php                                            
 ------ ---------------------------------------------------------------------- 
  99     Method Drupal\commerce_vado\Form\VadoGroupForm::save() should return  
         int but return statement is missing.                                  
 ------ ---------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php                                       
 ------ -------------------------------------------------------------------------------------------------- 
  55     Method                                                                                            
         Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase::setParentEntity()       
         should return                                                                                     
         $this(Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase)                   
         but return statement is missing.                                                                  
  62     Method                                                                                            
         Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase::setSelectedVariation()  
         should return                                                                                     
         $this(Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase)                   
         but return statement is missing.                                                                  
  175    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  400    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
 ------ -------------------------------------------------------------------------------------------------- 

I think most of this is probably handled by ignoring these warnings. See what commerce did here:
https://git.drupalcode.org/project/commerce/-/blob/8.x-2.x/phpstan.neon?...

tonytheferg β†’ changed the visibility of the branch 3421365- to hidden.

Bumping back to NR for the update hook.

Should probably have a couple of people test it.

You have to install the module without the patch, then apply the patch, then run drush updb etc.
All redirects that have an access count of 0 will have the last_access timestamp set to NULL.

Thanks for the review!
Yeah, I should write an update hook.

This is better for the reports test: (lines 51-57)

    // The popular report will show all aliases, ordered by the most used one.
    $this->drupalGet('admin/config/search/redirect/popular');
    $this->assertSession()->elementContains('css', 'tbody tr:first-child td:nth-child(2)', 'bar');
    $this->assertSession()->elementContains('css', 'tbody tr:first-child td:nth-child(6)', '5');
    $this->assertSession()->elementContains('css', 'tbody tr:last-child td:nth-child(2)', 'foo');
    $this->assertSession()->elementContains('css', 'tbody tr:last-child td:nth-child(5)', 'Never');
    $this->assertSession()->elementContains('css', 'tbody tr:last-child td:nth-child(6)', '0');

+ // Initial field values should be 0. Redirects should be considered

0 should be changed to NULL

Here are the basic tests added with NULL value.

The maintainer should decide what way this should be implemented in views so that those can be reworked and so that tests can be rewritten.

Here is a patch with the function. The maintainer should decide what way this should be implemented in views so that those can be reworked and so that tests can be rewritten.

Why is Meter Number removed?

I cannot get rates with the patch.

My credentials are current, but all I get is:
Authorization token is missing. Make sure it is included

#0 /var/www/html/vendor/whatarmy/fedex-rest/src/FedexRest/Services/Rates/CreateRatesRequest.php(353): FedexRest\Services\AbstractRequest->request()
#1 /var/www/html/web/modules/contrib/commerce_fedex/src/Plugin/Commerce/ShippingMethod/FedEx.php(479): FedexRest\Services\Rates\CreateRatesRequest->request()
#2 /var/www/html/web/modules/contrib/commerce_shipping/src/ShipmentManager.php(89): Drupal\commerce_fedex\Plugin\Commerce\ShippingMethod\FedEx->calculateRates(Object(Drupal\commerce_shipping\Entity\Shipment))
#3 /var/www/html/web/modules/contrib/commerce_shipping/src/Plugin/Field/FieldWidget/ShippingRateWidget.php(151): Drupal\commerce_shipping\ShipmentManager->calculateRates(Object(Drupal\commerce_shipping\Entity\Shipment))
#4 /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php(459): Drupal\commerce_shipping\Plugin\Field\FieldWidget\ShippingRateWidget->formElement(Object(Drupal\Core\Field\EntityReferenceFieldItemList), 0, Array, Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php(219): Drupal\Core\Field\WidgetBase->formSingleElement(Object(Drupal\Core\Field\EntityReferenceFieldItemList), 0, Array, Array, Object(Drupal\Core\Form\FormState))
#6 /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php(120): Drupal\Core\Field\WidgetBase->formMultipleElements(Object(Drupal\Core\Field\EntityReferenceFieldItemList), Array, Object(Drupal\Core\Form\FormState))
#7 /var/www/html/web/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(186): Drupal\Core\Field\WidgetBase->form(Object(Drupal\Core\Field\EntityReferenceFieldItemList), Array, Object(Drupal\Core\Form\FormState))
#8 /var/www/html/web/modules/contrib/commerce_shipping/src/Plugin/Commerce/CheckoutPane/ShippingInformation.php(335): Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object(Drupal\commerce_shipping\Entity\Shipment), Array, Object(Drupal\Core\Form\FormState))
#9 /var/www/html/web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(546): Drupal\commerce_shipping\Plugin\Commerce\CheckoutPane\ShippingInformation->buildPaneForm(Array, Object(Drupal\Core\Form\FormState), Array)
#10 [internal function]: Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->buildForm(Array, Object(Drupal\Core\Form\FormState), 'order_informati...')
#11 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array(Array, Array)
#12 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(283): Drupal\Core\Form\FormBuilder->retrieveForm('commerce_checko...', Object(Drupal\Core\Form\FormState))
#13 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(224): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\MultistepDefault), Object(Drupal\Core\Form\FormState))
#14 /var/www/html/web/modules/contrib/commerce/modules/checkout/src/Controller/CheckoutController.php(143): Drupal\Core\Form\FormBuilder->getForm(Object(Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\MultistepDefault), 'order_informati...')
#15 [internal function]: Drupal\commerce_checkout\Controller\CheckoutController->formPage(Object(Drupal\Core\Routing\RouteMatch))
#16 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#17 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#18 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#19 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#20 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#21 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#22 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /var/www/html/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /var/www/html/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}

The first section of the request is missing access_token

	Sending FedEx request.
\FedexRest\Services\Rates\CreateRatesRequest::__set_state(array(
   'api_endpoint' => '/rate/v1/rates/quotes',
   'access_token' => '',
   'production_mode' => false,
   'production_url' => 'https://apis.fedex.com',
   'testing_url' => 'https://apis-sandbox.fedex.com',
   'raw' => false,
   'shipper' => 

LMK Thanks

Ah, have to add the package manually.

For any trying to test this, you need to run:
composer require whatarmy/fedex-rest

For the patch to work.

Seeing this after applying the patch when creating or editing a shipping method:

Error: Class "FedexRest\Services\Ship\Type\PickupType" not found in Drupal\commerce_fedex\Plugin\Commerce\ShippingMethod\FedEx->defaultConfiguration() (line 223 of modules/contrib/commerce_fedex/src/Plugin/Commerce/ShippingMethod/FedEx.php).
Drupal\commerce_shipping\Plugin\Commerce\ShippingMethod\ShippingMethodBase->setConfiguration(Array) (Line: 74)
Drupal\commerce_shipping\Plugin\Commerce\ShippingMethod\ShippingMethodBase->__construct(Array, 'fedex', Array, Object, Object) (Line: 174)
Drupal\commerce_fedex\Plugin\Commerce\ShippingMethod\FedEx->__construct(Array, 'fedex', Array, Object, Object, Object, Object, Object, Object, Object, Object) (Line: 193)
Drupal\commerce_fedex\Plugin\Commerce\ShippingMethod\FedEx::create(Object, Array, 'fedex', Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('fedex', Array) (Line: 83)
Drupal\Component\Plugin\PluginManagerBase->createInstance('fedex', Array) (Line: 103)
Drupal\commerce\Plugin\Commerce\InlineForm\PluginConfiguration->buildInlineForm(Array, Object) (Line: 143)
Drupal\commerce\Plugin\Field\FieldWidget\PluginSelectWidget->formElement(Object, 0, Array, Array, Object) (Line: 26)
Drupal\commerce\Plugin\Field\FieldWidget\PluginRadiosWidget->formElement(Object, 0, Array, Array, Object) (Line: 448)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 216)
Drupal\Core\Field\WidgetBase->formMultipleElements(Object, Array, Object) (Line: 117)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object) (Line: 186)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 121)
Drupal\Core\Entity\ContentEntityForm->form(Array, Object) (Line: 107)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object) (Line: 25)
Drupal\commerce_shipping\Form\ShippingMethodForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('commerce_shipping_method_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

The 2 failed tests are from dev. I can add tests once we get feedback. NR for feedback from maintainers.
πŸ‘

This patch doesn't yet have the tests added back in, but is a simple approach to addressing #23. The wording of the setting needs some thought, but the default setting of TRUE would leave sites as they are on checkout. Site builders could turn off automatic recalculation on whatever form displays they want then.

Patch applied cleanly, and now I am getting rates, where first class is completely broken.

Setting the priority to major, as people's sites might be returning no rate whatsoever because first class is no longer supported and completely replaced by Ground Advantage.

Thanks for the patch!

Not sure. Maybe share a screenshot of the view and a video going through all the settings and variables.

Yeah, noticing this in migrations as well, rolling back shipments causes all the shipping profiles to get deleted.

Marking as fixex. If you continue to have issues, please open up a new issue with exact steps to reproduce.
Thanks!

Committed as it's a simple enough fix, and I need the new tests in place for other work. Going to publish a new release. Feel free to follow up on this issue, I will leave it open.

Better comments and a couple of increment checks added on non attribute, non modal messages.

ok, fixed the variation cart form test, and the only buttons I should need to wait on are the modal buttons. reverted the rest to press button.

Vado may still not work as the tests would need to grab the latest dev push.

committed to dev so I can work on other issues with this change incorporated.

Production build https://api.contrib.social 0.61.6-2-g546bc20