AjaxCartEventSubscriber::$entityTypeManager declaration is redundant / problematic

Also, another possibility is to skip overridding the parent constructor all together by doing the following:

calls:
      - [setRequestStack, ['@request_stack']]

With the changes from the MR, the code is now protected from changes made to the parent constructor.
Without the change, the current code would break due to the changes made in ✨ Provide service aliases for autowiring Active .

Thanks. NW as this broke tests.

Can you actually re-run the tests with the current code as I'm not sure the changes are causing the break.

Yeah I keep all the pipelines current tests should run something broke. If you go to the repository and check pipelines you'll see that our last commit on dev all the pipelines passed so it's the change.

Thanks! Is there any concerns with backwards compatibility here?
I am assuming this change won't work on commerce 2.x?

Why would this change not work with Commerce 2? The code is redeclaring a variable already defined by the parent and there is no reason for that.
This change can be safely committed.

Thanks!

This broke stuff. 🐛 Errors in the EventSubscriber when adding to cart Active

Nope, this isn't what broke stuff. The Commerce change broke this... Let's follow up in the new issue that got created. I was trying to prevent this with the initial fix...

Closing this one in favor of 🐛 Errors in the EventSubscriber when adding to cart Active which has a fix.