- Issue created by @tonytheferg
Also, It would probably be good to add
->setDisplayConfigurable('view', TRUE);
to the base field to allow users to display this as it's good data to be able to display on the shipment.- First commit to issue fork.
-
jsacksick →
committed 6e6526df on 8.x-2.x authored by
tonytheferg →
Issue #3510400: Set the shipped timestamp from the ship transition
-
jsacksick →
committed 6e6526df on 8.x-2.x authored by
tonytheferg →
- 🇮🇱Israel jsacksick
Merged thank you! Not sure about the event subscriber naming, but figured out you probably copied what the commerce_order module is doing so it doesn't hurt to keep the naming consistent.
At the same time, we could have reused the ShipmentSubscriber which already reacts to the ship transition (even though it reacts to the post transition).
The advantage of having this logic in a separate subscriber is that it's easier to actually remove the subscriber definition if needed...
- 🇮🇱Israel jsacksick
Why is that? I can also remove the subscriber :) since this feature wasn't really requested by anyone else but I think it's a fine feature.
I only set the date immediately for USPS shipments that we ship from our store. We have drop ships from other vendors where we use api callbacks to set the ship time off the data from the carrier.
-
jsacksick →
committed 820c7dc3 on 8.x-2.x
Issue #3510400: Revert the event subscriber added.
-
jsacksick →
committed 820c7dc3 on 8.x-2.x