While working on #3251430: Sort out order item matcher behavior when sync quantity is off. → , it occurred to me that we never did address the major concern with the sync quantity off data model.
If a site builder sets up a discount structure based on what they think to be required items in a bundle, and they neglect to turn sync quantity on for that bundle, a customer can add that bundle to the cart that has a discount, and simply remove any items they might not want while still receiving the discount for the remaining items.
It seems to me that we should restrict the entire Commerce Vado discount system to only be applied if sync quantity is on.
I would be glad to hear other thoughts on this. Maybe there is a use case where this sort of thing is fine, but it certainly seems like there is more potential for a site owner to get burned than there is benefit. At the very least we should set some sort of very clear warning.
This also brings to mind a second potentially significant issue. Our required checkbox on the group entity allows a site builder to require that items must be selected within that group. If sync quantity is off on the parent variation, the Vado add to cart form will require the selection of the item, but the shopping cart will not require that it stays in the cart.
Needs work
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This does not apply to commerce_vado 3.0.2. Is it needed for that version? it is on the module page.
Yes it still applies to this version. It's just the nature of the way the module works that if sync quantity is off and your discounting products that you can remove those products from the cart and break down the discounted bundle