- Issue created by @davidwhthomas
- Merge request !34Set shouldClearValues to true when product variation attribute is changed. → (Open) created by davidwhthomas
Thanks for posting. Seems simple enough. NW as this will need test coverage before adding.
- 🇳🇿New Zealand davidwhthomas
Thanks for checking.
I had a look earlier and couldn't find any existing tests related to, for example the group add to cart form and clearing the group widget on product variation title selection change.
As the MR passed the existing pipeline tests, I have assumed this minor update is ok there.
However, do you have any recommendation on where such a test would best be added? I'm away from the office currently, but I'm not basing the requirement of needing tests off existing tests, but rather establishing the support of attributes. Currently the module doesn't claim to support attributes, so if we do offer to support attributes, it needs test coverage.
- 🇳🇿New Zealand davidwhthomas
Fair enough. FWIW, other than the group add to cart form widget not resetting when the product attribute selection changes (fixed with this patch), the commerce_vado module appears to work well when using the product attribute widget for the product variation selection.