- Issue created by @as_vard
- 🇦🇲Armenia as_vard Yerevan
diff --git a/modules/direct_checkout_by_url/direct_checkout_by_url.info.yml b/modules/direct_checkout_by_url/direct_checkout_by_url.info.yml index dcc9d96dc..6d4164e9c 100644 --- a/modules/direct_checkout_by_url/direct_checkout_by_url.info.yml +++ b/modules/direct_checkout_by_url/direct_checkout_by_url.info.yml @@ -1,7 +1,7 @@ name: Direct checkout by URL description: Provides a URL where you can send a user directly into checkout by a URL pattern. core: 8.x -core_version_requirement: ^8 || ^9 +core_version_requirement: ^8 || ^9 || ^10 type: module dependencies: - commerce:commerce_product
- Status changed to Needs review
over 1 year ago 6:25pm 28 March 2023 - Status changed to Needs work
about 1 year ago 4:09pm 15 August 2023 - 🇺🇸United States rishi kulshreshtha
This needs work as
assertEqual()
will be removed in Drupal 10.FILE: web/modules/contrib/direct_checkout_by_url/tests/src/Functional/RedirectTest.php STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 128 Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertEquals() instead. --------------------------------------------------------------------------------
- @rishi-kulshreshtha opened merge request.
- Status changed to Needs review
about 1 year ago 4:16pm 15 August 2023 - 🇺🇸United States rishi kulshreshtha
Back to Needs Review, for someone looking to apply this as a patch can use https://git.drupalcode.org/project/direct_checkout_by_url/-/merge_reques...
- Status changed to Fixed
about 1 year ago 12:44pm 16 August 2023 - 🇺🇸United States rishi kulshreshtha
This issue is good to close, as the only remaining issue was committed by the author.
- Status changed to Needs work
about 1 year ago 4:36pm 16 August 2023 - 🇳🇴Norway eiriksm Norway
Thanks for following up and watching the issue 🤓
The test change was indeed committed, but the very much required info.yml change is not. So this module is still not compatible with Drupal 10, and would require a small patch in this issue. Back to needs work for this, and looking forward to a merge request ✌️🤓
- First commit to issue fork.
- last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - Status changed to Needs review
about 1 year ago 7:08am 17 August 2023 - last update
about 1 year ago 3 pass - last update
about 1 year ago Build Successful -
eiriksm →
committed c7cb0596 on 8.x-1.x authored by
Rishi Kulshreshtha →
Issue #3350484 by as_vard, keshavv, Rishi Kulshreshtha, eiriksm: Drupal...
-
eiriksm →
committed c7cb0596 on 8.x-1.x authored by
Rishi Kulshreshtha →
- Status changed to Fixed
about 1 year ago 9:49am 17 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.