The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฆ๐บAustralia mayurngondhkar Melbourne
https://www.drupal.org/project/drupal/issues/3129235#comment-15175457 โจ Allow embedding multiple Media Entities using the Media Library in CKEditor Needs work
Rerolled agains `9.5.x` - last update
over 1 year ago Patch Failed to Apply - ๐ง๐ชBelgium jOpdebeeck
We required this feature when upgrading to Drupal 10.1.2.
I rerolled the patch for use in drupal 10.1.x
Patch might not apply for 10.1.2 specifically. In that case, checkout the 10.1.2 core tag, apply the patch and if the hunk on
drupalMedia.js fails to apply, you can skip that and remake the patch after running yarn in the core folder:cd core
yarn install
yarn build:ckeditor5 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 29,466 pass, 1 fail - ๐ง๐ชBelgium glenndw
The previous patch had a problem when adding media.
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - ๐ฉ๐ชGermany 4kant
#34 doesnยดt apply any more after update from drupal 10.1.4 to 10.1.5
Thanks! - last update
about 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia vsujeetkumar Delhi
@GlennDW Interdiff should be there in #34, It's help others to understand the changes you have done.
@jOpdebeeck diff required while we rerolling. Please check the doc โ . - ๐ง๐ชBelgium Joris Handstanger
@vsujeetkumar Interdiffs on re-rolls are usually not really required, because only the patched context should be different on a re-roll and not the changes themselves.
That said, there were some issues with the last patch, so in this case an interdiff could indeed be useful :) - ๐ง๐ชBelgium Wannes DR Belgium ๐ง๐ช
And a reroll for Drupal version 10.3.5 as well.