#Triaged Media Initiative issue

โšก๏ธ Live updates comments, jobs, and issues, tagged with #Triaged Media Initiative issue will update issues and activities on this page.

Issues

The last 100 updated issues.

Activities

The last 7 days of comments and CI jobs.

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance DuaelFr Montpellier, France

    @queenvictoria Thank you for letting me know! You're right, I did a mistake rerolling this and making the patch. Here is a new one.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia queenvictoria

    Hey @DuaelFr applying that patch in 10.3.1 causes update.php to fail.
    Specifically: removing the following lines allows the database update to pass:

    +    'media_post_update_oembed_loading_attribute' => '11.0.0',
    +    'media_post_update_set_blank_iframe_domain_to_null' => '11.0.0',
    +    'media_post_update_remove_mappings_targeting_source_field' => '11.0.0',
  • Maybe no new information here, but I'm also having this issue and being driven crazy by it, so I'll include what I've seen just in case.

    My CKE5 content is a simple <drupal-media> element with a link added and the "Convert line breaks into HTML" text filter is near the top of the list. This is what the source looks like:

    <a href="/node/106"><drupal-media data-entity-type="media" data-entity-uuid="3b055276-978a-445d-83e5-5ac8c217030a">&nbsp;</drupal-media></a>
    

    This is the rendered output:

    <div class="c-basic-text o-wysiwyg">
      <p>
        <a href="/node/106"><br></a>
      </p>
      <article class="media media--type-image media--view-mode-default">
        <p>
          <img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
        </p>
      </article>
      <p></p>
    </div>
    

    Note the <p> that precedes the <article>. It contains an <a> that contains only a <br> and which of course results in a duplicate link (which is bad practice). None of these elements were present in the CKE5 source.

    I figured out (as others have) that if I turned off the "Convert line breaks into HTML" text filter, the image link began working as expected and the rendered output looked like this:

    <div class="c-basic-text o-wysiwyg">
      <a href="/node/106">
        <article class="media media--type-image media--view-mode-default">
          <img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
        </article>
      </a>
    </div>
    

    So that solves it! But I don't want to turn off the filter completely because that might mess up existing content that relies on the line breaks being converted, so instead I moved the "Convert line breaks into HTML" text filter to the bottom of the filter list. That results in this rendered output:

    <div class="c-basic-text o-wysiwyg">
      <p>
        <a href="/node/106"></a>
      </p>
      <a href="/node/106" data-once="lifespan_extlink">
        <article class="media media--type-image media--view-mode-default">
          <img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
          <br>
        </article>
      </a>
    </div>
    

    If you're playing along, you can see that we have an image link that works, but now the duplicate link is back. This time it does not have a <br> in it. Instead, a <br> mysteriously appears after the <img>. Again, neither the extra link nor the <br> were present in the CKE5 source.

    Another wrinkle: I noticed that if I add an image caption to the linked <drupal-media> element, I get this rendered output:

    <div class="c-basic-text o-wysiwyg">
      <figure role="group" class="caption">
        <a href="/node/106">
          <p></p>
          <article class="o-img-wrapper">
            <img class="media media--type-image media--view-mode-default" src="/system/files/2024-06/img_0243_0.jpeg" alt="Kittens" loading="lazy">
            <br>
          </article>
        </a>
        <p>
          <a href="/node/106" data-once="lifespan_extlink"></a>
        </p>
        <figcaption>test caption</figcaption>
      </figure>
    </div>
    

    Of note here is that the image link is correctly formed and works, but we again have a duplicate link and a <br> following the <img>.

    My default display for images does not include any link. This is happening on 10.2.x.

    Again, as others have already noted, it seems like turning the filter off if is currently the best option for getting a correctly linked image and no problematic markup.

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance DuaelFr Montpellier, France

    Rerolled !3037 MR against 11.x
    Patch attached for people needing this on 10.3.1

Production build 0.69.0 2024