@vivek Thanks for the reminder, I added the credits. I was too used to the time where the checkboxes were checked by default when somebody was uploading a file.
phjou → created an issue. See original summary → .
I guess we want to set the context only if the input name is not empty. Otherwise it looks good
$form['#cache']['contexts'][] = 'url.query_args:' . $input_name;
That would be great to commit this, I wanted to use the module but couldn't because it is not compatible Drupal 11.
Uploading new patch hopefully now decorrelated from [#315064 ]
Just posting a patch that I used on my side to be able to get 2 years per page.
That's probably a starting point to get tested. I got quite some issues while developing it, so there might be some more problems. But if the new granularity amount is 1, then the code should basically do the same as before.
Yes I believe I tried the latest patch. Works fine when no cache is set on the view, but on tag based cache, my view was resetting the pager to only one page using this pager. My view is also set to use ajax.
It doesn't seem like the feature is on the branch. That would indeed be an amazing thing to have.
phjou → changed the visibility of the branch 3513554-allow-to-keep to hidden.
Just tried this patch, it doesn't seem to work.
I have a filter on the Year and all the values are disappearing with the patch, while before the options were there but not working at all.
Just got the same error, patch #118 fixes the issue for us.
After some research, it seems that it is "CKEditor 5 Word Count" that is responsible for this error in my case. Uninstalling that module makes Ckeditor load again and the rest of the plugin I use "WProofreader" and "Paste Filter" are working fine.
This doesn't happen all the time for me. It seems to happen when adding a new block to a page using layout builder and I do have the layout_builder_iframe_modal module as well. When editing a block, it works well, it is only when adding a new one that the problem occurs.
The patch doesn't fix that loading issue for me.
Patch works well, thanks!
The patch works well! Without it the module doesn't work at all.
Just posting an updated patch for the latest version of the module.
It seems like the pull request needs a rebase.
I think I got the same issue. But I got the issue in Layout builder when adding a new basic block. The patch doesn't seem to fix it for me.
@emerham It seems like this is exactly what is happening for me. I just rearranged the priority of my text formats and got that error.
I think I have the same issue and my view is a page, so not sure why.
Also it seems that I had it before and now the filter is marked as broken/missing.
I wonder if something changed in the code that messed that up.
It seems like the issue that is linked is fixing most of the problem, the only remaining problem I see is that the thumbnail doesn't reload immediately.
I guess since the media didn't change technically, drupal doesn't reload the media when saving and the image is not updated, you need to reload the page to see the new thumbnail.
@goldin You need to use the stripe_webform module in addition of the stripe module if you want to be able to set the receipt_email in a webform. This issue was a parent one that was blocking us on the stripe webform module.
https://www.drupal.org/project/stripe_webform →
Actually breaks W3C compliance. When not filled, it is adding an empty target attribute which is not valid.
target=""
@hongpong
I really like your suggestions.
The weight feature is definitely something we need to add. That could be problematic for some projects in case plugins are affecting the same data and the order matters.
I also like the idea of adding API versions in there, that would give the module more flexibility for the future and be able to support different plugins versions at the same time. Not sure if this will block this issue much longer though. When I needed to do my migration 4 years ago, that plugin system was definitely a big missing piece to be able to actually use that module.
The patch doesn't seem to work with Ckeditor5, it gave me so much trouble to find out that it was the patch messing up the upgrade to Ckeditor 5.
Didn't do the tests.
Just added the None option. Very useful feature.
Wa had the same issue, hook #3 seems to do the trick, thanks!
I would probably set the cache to only be set on the query parameter and not the whole URL. That way we have a unique cache when the parameter is not there.
$form['#cache']['contexts'][] = 'url.query_args:' . $input_name;
PS: I didn't test this code, just followed the documentation:
https://www.drupal.org/docs/drupal-apis/cache-api/cache-contexts →
Merge requests done, to change method into a static function to avoid the crash when the call is done using batch.
phjou → created an issue.
Merge request done, the change is very simple and make complete sense to check for a value to be set before manipulating it.
Thank you for noticing, I just fixed it on the project page and will push the README change.
Thanks for the patch, it has been commited.
I will also remove Drupal 8 & 9 at the same time.
Adding Drupal 11 and removing Drupal 8 & 9
Drupal 11 has been released, just merged the Drupal 11 compatibility to avoid blocking people to use this module on newer version of core.
This has been fixed as part of 📌 Automated Drupal 11 compatibility fixes for link_no_protocol Needs review
Fix has been deployed on the dev branch. The solution has been merged with 🐛 Module doesn't work for a url with 'www' prefix. Active
Please feel free to reopen if the issue is still happening on the dev branch. I'll create a release with teh fix in a while to let you some time to test the fix.
Ok I've been investigating this at the same time as 🐛 PHP error for url with trailing slash Active that is related since the same patrt of the code is responsible for crashing.
I've released a fix on the dev branch. Feel free to reopen the ticket if the issue is still happening.
The issue has actually has been fixed with the Drupal 11 support. Thank you.
It seems like a fait fix to me. I merged it.
Thanks, the patch has been merged.
Added Drupal 11, but also removed support for Drupal 8 & 9.
I confirm I have the same issue, I can delete the workflow state, and then the nodes that were using it have a broken revisions list page.
Patch attached
It would be best practice to keep the MediaInterface and just fix the use to be based on core:
Drupal\media\MediaInterface
Works well, thank you!
Did anybody found how to do that?
I did try and the block with the paragraph is not even showing up at all for me...
This module was supposed to stay quite simple like the Search Block from Core. So I am not sure if this module should include an advanced feature like this.
But you probably can use this module to achieve it:
https://www.drupal.org/project/views_exposed_filter_blocks →