I guess it would be nice to update the module to "Unsupported status" as said in comment #5.
I would suggest to merge 🐛 Cannot uninstall with remaining lockr keys Needs review for one last release because it is not possible to uninstall the module if you have any remaining Lockr keys.
Merge request done.
If anybody needs the patch:
https://git.drupalcode.org/project/lockr/-/merge_requests/21.patch
Marking this as fixed since the merge request has been merged
Ok pull request done. It allows support for translation directly using Alttext.ai
Let me know if that works, it seems to work pretty well on my end.
The patch from #55 works very well for the most part.
I do have an issue for block titles, when accepting changes, the "Block description" field in the interface doesn't seem to be used and doesn't update the block title.
I confirm this issue, I do have the same problem.
I had to do the same as damienmckenna to uninstall. Pretty annoying but not sure there is a solution as long as the module is altering the substituting itself to the core plugin.
I confirm no issues with alpha5, alpha6 on the other hand creates that issue
Due to latest version, the description was conflicting preventing the patch to apply.
@anybody
I added grevil and also gave you administer maintainers permissions.
Patch attached, it is just checking that the return is not NULL before sending it to trim
Thank you. I just created the issue #3548268: TypeError: trim(): Argument #1 ($string) must be of type string, null given in trim() → . I'll drop a first patch in there in case other people have the same problem.
OOps, I uploaded the wrong patch. This should work better with that one, sorry.
Rerolled the patch to work on the latest version.
The patch does not contain this line that was in the branch:
'visible' => $entity_type->id() == 'node',
That defies the purpose of the whole ticket to make it work with all entities and not just nodes.
It seems like this change broke some pages on my website when there is a special character �
If I comment this line in MetaNameBase, the page works again. I guess I'll try to get rid of that character to fix the issue, but that would be better if it was safer and not crash the whole page because of a character.
$value = preg_replace('/\s+/u', ' ', $value);
Seems like it does not apply anymore, rerolled from #88
It looks like a duplicate of 📌 Automated Drupal 11 compatibility fixes for imageapi_optimize_webp Needs review
Ok it is now time to upgrade to D11, I pushed also the D11 change on the branch.
Thez patch from rector was missing some stuff for me
Sorry for the delay, I both added you as maintainers.
I just have tried the patch, the checkbox in views shows as expected. But after having it checked, I get a fatal error:
Error: Call to a member function getName() on array in Drupal\taxonomy\Plugin\views\filter\TaxonomyIndexTid->valueForm() (line 248 of core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php).
Added new patch.
Seems like I have a bug where I've explicitly set a view mode and it is overriden with the default one.
Replacing this
if ($node->getAttribute('data-view-mode') && isset($this->settings[$bundle])) {
With this
if (!$node->getAttribute('data-view-mode') && isset($this->settings[$bundle])) {
It seems to work, if we have set a specific view mode 'data-view-mode', the patch should not override.
It would be nice if this was merged. Drupal 11 has been released for a while now.
@thomas.frobieter Yes I can create a release if I get a valid merge request to merge in.
I can also add you as maintainer if you want to?
The patch doesn't seem to apply anymore.
It would be cool to also have dnt=1 parameter for vimeo
That's the patch I used in addition if somebody has the same issue.
Just for information we encountered an issue on Drupal 11 where isFunction is undefined.
THe following code crashes:
$.isFunction($.colorbox)
I believe the latest version of JQuery that comes with Drupal 11 doesn't have isFunction anymore.
phjou → created an issue. See original summary → .
I confirm, I am getting the same error:
The website encountered an unexpected error. Try again later.
Drupal\Core\Field\FieldException: Attempt to create a field 'recycle_bin' without a bundle. in Drupal\field\Entity\FieldConfig->__construct() (line 132 of core/modules/field/src/Entity/FieldConfig.php). I agree with you that limit the choices for the time being is a good quick fix. We should add a comment on the settings page to explain why other entity types are not showing otherwise that can make some site builder/developers search for hours and not understanding why.
@nkoporec Thanks a lot.
I have created an alpha release with a few fixes and Drupal 11 support.
Hopefully that helps a few people, if there were other users of that module.
This has been fixed
Drupal 11 support has been added on branch 8.x-2.x to avoid issues on websites with module installed.
The automatic patch was not enough, the settings form was crashing completely due to wrong constructor signature. This has been fixed, the rest seemed to work as expected from what I could see.
Testing patch
It would be great to this merged to be able to switch to Drupal 11
@ryanrobinson_wlu Fixed.
You can upgrade to 1.1.7 in order to get the change but I would recommend to upgrade to 1.2.0.
I also dropped support for Drupal 8 & 9 that are not supported anymore on 1.2.0.
Thanks for your help!
@ryanrobinson_wlu I am not sure to follow what is needed here.
If I download the latest release (1.1.6), the schema file is in there.
What error do you have exactly?
Hi,
I added @mably as maintainer with full access.
Let me know if you do not have access but you should be able to do anything now.
The patch doesn't seem to handle media. Only taxonomy terms and nodes.
In case people need a patch until the next release is created:
https://git.drupalcode.org/project/text_with_title/-/merge_requests/4.patch
Oh I was adjusting my pull request since I just noticed I didn't use the version 2 branch, but apparently you already merged.
You're so fast! Thanks a lot.
phjou → changed the visibility of the branch 3522280-fatal-error-when to hidden.
It would be cool to get Drupal 11 support merged.
Added drupal 11 compatibility - drupal 8 and 9 dropped since they are deprecated
Pull request is done, just adding drupal 11 to the composer.json
Same here ^, hopefully this gets merged soon.
@vivek Thanks for the reminder, I added the credits. I was too used to the time where the checkboxes were checked by default when somebody was uploading a file.
phjou → created an issue. See original summary → .
I guess we want to set the context only if the input name is not empty. Otherwise it looks good
$form['#cache']['contexts'][] = 'url.query_args:' . $input_name;
That would be great to commit this, I wanted to use the module but couldn't because it is not compatible Drupal 11.
Uploading new patch hopefully now decorrelated from [#315064 ]
Just posting a patch that I used on my side to be able to get 2 years per page.
That's probably a starting point to get tested. I got quite some issues while developing it, so there might be some more problems. But if the new granularity amount is 1, then the code should basically do the same as before.
Yes I believe I tried the latest patch. Works fine when no cache is set on the view, but on tag based cache, my view was resetting the pager to only one page using this pager. My view is also set to use ajax.
It doesn't seem like the feature is on the branch. That would indeed be an amazing thing to have.
phjou → changed the visibility of the branch 3513554-allow-to-keep to hidden.
Just tried this patch, it doesn't seem to work.
I have a filter on the Year and all the values are disappearing with the patch, while before the options were there but not working at all.