- 🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
Nice feature.
Should we make this a checkbox in the block configuration to enable or disable this feature? And we would enable this by default.- If people want to customize in their theme, it might be best to have an option to not add any javascript.
- It might be best if the javascript was based on a class that we add ourselves because in a theme the class "form-search" could be missing or used in other spots. - Status changed to Needs work
almost 2 years ago 2:08am 3 February 2023 - Status changed to Needs review
7 months ago 3:42pm 4 June 2024 - Merge request !8Issue #3320560: Added default value and cache context to search api form. → (Open) created by Vivek Panicker
- Status changed to RTBC
5 months ago 8:46am 6 August 2024 - 🇮🇳India atul_ghate
I have reproduced the issue successfully.
The MR8 is applied cleanly.I followed the steps below to reproduce the issue:
1.Cloned the 1.0.x version of the module.
2.Installed its dependencies and enabled both modules.
3.Create a view for content and add exposed filter and configure
4.add serach api form by configuring it with key and action view url
5.Reproduced the issue both without MR8 changes and with MR8 applied.
Changing its status to RTBC. - Status changed to Needs work
about 1 month ago 1:12pm 15 November 2024 - 🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
I would probably set the cache to only be set on the query parameter and not the whole URL. That way we have a unique cache when the parameter is not there.
$form['#cache']['contexts'][] = 'url.query_args:' . $input_name;
PS: I didn't test this code, just followed the documentation:
https://www.drupal.org/docs/drupal-apis/cache-api/cache-contexts →