🇮🇳India @atul_ghate

I have reviewed and tested MR!65. The changes look good to me based on the proposed solution. I have verified that the module works without any errors after the changes were applied (there are no deprecated warnings). I'm marking it RTBC."

Added MR as per #6, please review.

issue is already fixed in 2.0.x version.

Yes, i have installed this module with composer as well, still the same issue.

I can also confirm that saving the default configuration fixes this issue.

I am not able to installed this module due to missing libraries error.

mradcliffe → credited atul_ghate → .

Hi @jurgenhaas i have converted patch to MR please review.

atul_ghate → made their first commit to this issue’s fork.

Hi @pemela,
Okay you can go ahead and process it

Created MR for 11.1.x branch please review.

I am unable to reproduce the issue on the 11.x branch. Below are the steps I followed to replicate it:

1.Cloned the 11.x branch.
2.Installed the Admin Toolbar module.
3.Installed the Admin Toolbar and Contextual Links modules.
However, when I click on the Edit button, I do not encounter the mentioned error (please see the attached video for reference).

Let me know if I am missing something or if any steps need correctio

I will work on this issue.

I will work on this issue.

I have converted patch #2 into a Merge Request. Please review it.

atul_ghate → changed the visibility of the branch 3412344-email-address-field to active.

atul_ghate → changed the visibility of the branch 3412344-email-address-field to hidden.

atul_ghate → made their first commit to this issue’s fork.

I will work on this issue.

I am not able to reproduce this issue.

atul_ghate → made their first commit to this issue’s fork.

My apologies for the numerous commits. I’ve checked and compared each line. Please review.

Created MR as per proposed solution please review

I have reviewed and applied MR2. It resolved the mentioned issue, and we can now install this module on Drupal 11 without any errors. Changing the status to RTBC. See the attached video for reference.

I have reviewed and applied MR12. It resolved the mentioned issue and looks good to me. Changing the status to RTBC. See the attached video for reference.

I have reviewed and applied the changes as a patch. The content and home page have been updated as per the issue requirements. Everything looks good to me, so I am moving it to RTBC. Please see the attached video for references.

I have reviewed and applied patch. it resolved the mentioned issue, changing status to RTBC (see attached video)

I've successfully reproduced the issue and reviewed the Merge Request !10338 on the 11.x branch. I also applied the patch without any problems, and the pipeline is passing. changing status to RTBC. (please see attached screenshot)

Hi @diwakar07 i have fixed the conflict and update the issue id please review.

I will work on this issue.

Hi @quietone,

Thank you for the feedback! I'll keep this in mind next time

Hi @a.dmitriiev, thank you for correcting me during the testing.

I went through the verification process again, following the steps outlined in comment #28. (You can check the attached video for reference.)
Test Results:
1.No errors occurred when I ran the same recipe twice.
2.Everything is functioning correctly, and all tests have passed.
Since everything is working as expected, I'm changing the issue status to RTBC.

I followed the steps to reproduce the issue as outlined below:

1Installed Drupal with the standard profile.
2.Switched to the 3483353-entity-copy-use-existing branch from 11.x.
3.Created a recipe with the createCopy configuration action.
4.Ran the recipe twice and verified the result on the site.

Test result: After running the recipe twice, I am still encountering the same error as mentioned (please refer to the attached video for reference).

Please let me know if there are any steps I might be missing in order to properly reproduce this issue? Thank you.

Hi @dpi
As per Proposed resolution I've followed same technique as Drupal\Core\Entity\Sql\DefaultTableMapping

atul_ghate → made their first commit to this issue’s fork.

atul_ghate → made their first commit to this issue’s fork.

I have rerolled the patch for 11.x and fixed the ESLint issues as well, but I am keeping the issue in 'Needs Work' status for the mentioned tags.

I have successfully reproduced this issue, added fixes in the MR and the patch as well. Please review and merge.

I have fixed all the PHPCS issues, but the pipeline is still showing PHPCS warnings.(see attached screesnhot)

atul_ghate → made their first commit to this issue’s fork.

atul_ghate → made their first commit to this issue’s fork.

Hi poker10, I agree with your proposed solution. However, in Drupal 11, when we click on the 'Reset Your Password' link, the site breaks, and even modifying UserPasswordForm does not resolve the issue. Please see the attached video for more details.

I was also encountering the same error on the 11.x branch as mentioned in #12. I created Merge Request !9943 based on the changes suggested in #13. Please review and provide any additional feedback.

I've tried to reproduce the issue, but after installing the Commerce Email module and all required dependencies, the site is not working and showing an error (see attached screenshot). I've tested this on both Drupal 10 and 11 but encountered the same error during installation.

Hi @kopeboy, if MR2 works well, we can change the status to RTBC instead of Active, as per the Drupal contribution guidelines.

Hello @clarkssquared,
Could you please elaborate on what exactly is wrong according to the Drupal README standards? This will help me to make the necessary modifications more easily. Thank you!

MR!2 is not applying as a patch for the 1.1.x branch. Could you please raise a merge request specifically against 1.1.x

I am not able to reproduce this issue on Drupal 11.x. The steps I followed to reproduce are as below:

1.Clone Drupal 11.x and enable the Language and Content Translation modules.
2.Change the Manage Display settings for the media type and select the Thumbnail formatter with the Link to entity option enabled.
3.Create a Media type (image) and enable translation for it. Add an image with an English translation, then add a translation for another
language for the same media image
4.Add this media image to an Article node.
5.When I click on the image, it redirects me to the correct language version of the node.
Please let me know if there is anything I am missing.

Fixed issue for 2.x branch please review.

atul_ghate → made their first commit to this issue’s fork.

I have reviewed and applied the merge request !15 . It applied cleanly and added a configuration option to set the items per page as required. Everything is working well. Please refer to the attached video for details. I'm marking it as RTBC.

atul_ghate → changed the visibility of the branch 3478295-open-learn-more to active.

atul_ghate → changed the visibility of the branch 3478295-open-learn-more to hidden.

I have reviewed and applied the merge request, which resolved the mentioned issue. I am changing the status to RTBC (Reviewed and Tested by the Community). A video is attached for reference.

Hi @nicolas,

Could you please provide detailed steps to reproduce this issue? I am currently unable to replicate it on Drupal 11. To help us investigate, please mention:

The version of Drupal and PHP you are using.
Any specific settings or configurations you have applied to the form.
This information will make it easier to reproduce and debug the problem.

Thank you!

I am not able to reproduce this issue.

I will work on this issue.

Hi @fernly, there is no console.log placed in leaflet,drupal.js file please check again for version 10.2.x-dev.