- Issue created by @chrisfromredfin
- 🇮🇪Ireland lostcarpark
I think the problem with the current button is there is no way to interact other than to press it, which loads the drupal.org page, in the current tab.
If it's possible to convert it to a link, that would have the advantage that in addition to clicking it, you can hover over it to see the destination, and you can right-click to get options, including copy the URL, open in new window, open in incognito window.
It would also make it less essential to open the link in a new tab, since this could be achieved by ctrl-click or a right-click menu option.
That said, it seems unlikely that someone would want to navigate away from the site they are building to look at a module page, so I feel the default action should be to open in a new tab.
- First commit to issue fork.
- Merge request !593#3478295: Open Learn more action from detail page in new tab → (Merged) created by omkar-pd
- 🇮🇪Ireland lostcarpark
I've tested in DrupalPod.
The change looks good. The link behaves better, and is styled as a button, and the default action opens in a new tab.
The one thing I'm not completely happy about is the hardcoding of
#fff
in the:hover
style. However, I see this is based off the Claro theme styleproject__action_button
, so I'm not sure there's much we can do about it at present.Moving to RTBC.
- 🇺🇸United States chrisfromredfin Portland, Maine
just needs a
rel="noopener noreferer"
on the link since it's opening in _blank.As much as I normally would want to put an external link icon on it, I think that's best left to the site owner/theme to configure extlink or something.
So just that attribute!
- 🇮🇳India atul_ghate
atul_ghate → changed the visibility of the branch 3478295-open-learn-more to hidden.
- 🇮🇳India atul_ghate
atul_ghate → changed the visibility of the branch 3478295-open-learn-more to active.
-
chrisfromredfin →
committed e356ac1f on 2.0.x authored by
omkar-pd →
Issue #3478295: Open "Learn more" action from detail page in new tab
-
chrisfromredfin →
committed e356ac1f on 2.0.x authored by
omkar-pd →
Automatically closed - issue fixed for 2 weeks with no activity.