The main branch is fixed now. Hiding the other branch.
All the problems are fixed in Gin (light and drak mode) as well as Claro. This is up for another round of reviews.utkarsh_33 → changed the visibility of the branch change-ui-for to hidden.
Just to avoid confusions:-
change-ui-forbranch has completely working code.3484474-change-ui-forbranch has some issues which i had a hard time to figure out what went wrong while merging so i created a new branch to compare and show the working status.
Meanwhile i figure out what have i have messed up in the older branch someone reviewing the code can take the checkout of the new branch as it works as expected.
Thansks!- @utkarsh_33 opened merge request.
I added a fix that adds the classes to respective elements based on the themes.IMHO it can also be an approach to fix the issues rather that including a separate library via hooks(i might be wrong though).
We can still try to optimise the changes if the approach looks good.Marking it NR to get some feedbacks from @rkoller, @phenaproxima or someone else.