- 🇺🇸United States bernardm28 Tennessee
I was thinking on this items.
There is a button for add/install button but the items underneath i did not see them on the svelte file.
Those include- Message if not compatible
- # Installs
- Stable
- Maintain
- Link to Drupal.org
- 🇦🇺Australia pameeela
Based on the latest comments, this is blocked on not having the data about when a module was last updated.
On the UX side, I am not sure. As a few have pointed out, the updated date is not necessarily useful. But there is already a sort for 'Newest', and I think recently updated is more useful than that. Perhaps once this becomes unblocked we could replace the Newest filter with this?
(I tried to find where the 'Newest' sort was added to see if there was any discussion but I couldn't find it.)
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇦🇺Australia pameeela
I'm not in favour of this change, mostly I agree with #6. A few people have pointed out that the meaning might be lost on the target audience, and I must admit even I was not fully aware of the 'full release' terminology. I knew what it meant, but I stopped and thought 'wait is that really what we call it?'
I also don't think the difference is all that meaningful in contrib, as every module maintainer has a seemingly different definition for what is alpha/beta/RC etc. I think it would be an easier sell if there were consistency. It is a long list of options, with honestly not that much distinction and therefore not that much value to the user.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States MrMason
I've updated the code to make the list view function properly.
I'm trying to figure out the best way to handle it changing from grid and then back to list when you change the size of the display. I'll keep working on that issue or make it a separate issue from this one.
- 🇺🇸United States chrisfromredfin Portland, Maine
I think there's good enough consensus here, and that we're seeing this pattern in Claro in other places (ex.g. modules List page) - if the screen gets super wide, the text gets super wide. Not ideal - we all agree limiting line length is good for readability - but closing here because I believe this should be fixed upstream (Claro, ex.g.) and we should not deviate to the extent we're able.
- 🇺🇸United States leslieg
"Some of the items on the right panel below do not yet exist. I imagine I should leave a placeholder."
@bernardm28. Which items in the right sidebar are you refering to? - 🇮🇳India divya.sejekan
Verified the fix , the pointer cursor changes when hovered over the view command button
- 🇺🇸United States bernardm28 Tennessee
Since drupal already has a sidebar, I might copy some of its styles.
Some of the items on the right panel below do not yet exist. I imagine I should leave a placeholder.
- 🇦🇺Australia pameeela
Wrote up a whole response to this but realised that it only matters in the context of the existing modal. I have added a screenshot of that to the IS.
Short version: I think a one-liner is preferable, and there is somewhat of a precedent of using one liners in other docs → . It would save most people time, and can be pretty easily unpacked if someone needed to run one step without the other.
However, the current 'View commands' modal shows a description of each step as well as some basic troubleshooting for each. It might be tricky to merge these cleanly. Not impossible, but it would be more confusing.
So I think it's a question of saving some time vs possibly making it harder to follow if something goes wrong.
- 🇦🇺Australia pameeela
I think this is a really, really hard thing to covey with an icon! It is interesting that there are people strongly in favour of both. I don't see either one as being very indicative, and agree with #25 that the icon itself probably won't achieve much either way.
Coming into this issue I did not know what the blue check icon meant either, but looking at PB I was able to determine from the filters that it means 'Covered by a security policy'. However, given that this is also a default filter, I am not sure the icon is a good idea? It will add clutter to the UI, considering that every module will have it by default. So I guess the use case is someone who selects 'Show all'?
I think it would probably be better to add an icon if it's *not* actively maintained, as this is something to alert users to. Otherwise, nothing to see here. And I see now this was already suggested in #2!
Screenshot of the filter for reference:
- @bernardm28 opened merge request.
- 🇺🇸United States leslieg
@chrisfromredfin started work on this at DrupalCon Portland 2024 and will be continuing on that
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Do we need to think more high level about this? The "Types" are very Drupalistic being a Content type or a User Profile, but for findability, Project Browser's "Use Cases" are more appropriate.
And to be able to limit and sort recipes in Project browser, I am thinking we need a third sort, something along the lines that @chrisfromredfin is using "ingredients, dishes, and meals" to sort the impact/size of the recipes. See: https://drupal.tv/external-video/2023-11-19/drupal-recipes-what-are-they...
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States bnjmnm Ann Arbor, MI
Yay! That one little icon added a surprising amount of complexity and I'm glad to see it move to a nice farm up north.
-
bnjmnm →
committed 30e24a50 on 1.0.x authored by
Vighneshh →
Issue #3312056 by sime, mradcliffe, mherman-pro, anmolgoyal74, tderego,...
-
bnjmnm →
committed 30e24a50 on 1.0.x authored by
Vighneshh →
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇮🇳India divya.sejekan
I have reproduced the issue , but when i apply the patch , getting error