Trigger entity validation in \Drupal\Core\DefaultContent\Importer::importContent()

alexpott → credited larowlan → .

This was tricky, and revealed a flaw in our handling of duplicate file entities.

Turns out file entities cannot be duplicated by URI. That's validated at the entity level. Yet we specifically test for that -- the only reason that test passed before, is because we weren't doing entity validation.

So I refactored the file handling logic to do this, in order:

1. If there's no physical source file to be copied, there's nothing we can do. (This is the existing behavior.)
2. If the source file and destination file exist, but have different contents, then ensure the destination file will have a different name. (This is the existing behavior, changed slightly.)
3. Now that we know the destination URI, check if there's a file entity that already has it. If there is, then don't import the incoming file entity -- just use the existing one, and ensure that any other entities being imported in the current batch which reference the new file entity, will actually reference the existing one.
4. Finally, if there is no file entity for the destination URI, copy the physical file and update the URI of the file entity we're importing.

The test coverage probably has some gaps, and I do need to write explicit coverage that validation is triggered, but this is progress...

I suspect the test failures here are linked to #3442024: Account switching to user 1 is now fraught → , so postponing this issue on that one.

Great to see this close. I think the exception needs to have the file that caused it - if possible - or if not then the uuid not the ID.

Fixed a bug on the MR by moving the validation into the loop.

Committed and pushed 1736da1fcc5 to 11.x and f665255f6e7 to 10.3.x. Thanks!

Cherry-picked to ✨ Add recipes api as experimental API to core Needs review

This looks like a crucial addition for the "default content" functionality!

Check default content module for any existing issues about this.

Dare I ask … what was the outcome of this? 🫣

@Wim Leers in true Drupal fashion it does not look like entity validation has been considered... see
https://www.drupal.org/project/issues/default_content?text=validation&st... →
https://www.drupal.org/project/issues/default_content?text=validate&stat... →

😨

Automatically closed - issue fixed for 2 weeks with no activity.