- 🇺🇸United States smustgrave
With D7 approaching EOL soon I've started the process of triaging the D7queue here. Since there hasn't been any movement on this going to close out.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Actually, the
Component
config entity already handles this, largely. So we don't need all that infrastructure.But we're missing some validation here.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Wow, that looks much better! 👏
I'd even use the word impressive — it's nice to see that when we use Symfony's Validation component "as intended", that it is so much clearer than if there's Drupal's layer of abstraction (either config schema or Entity/Field/Typed Data) in between 🤯
Is there any documentation about how `#config_target` should/can be used?
- 🇺🇸United States tedbow Ithaca, NY, USA
@Wim Leers I changed this to use symfony/validator constraints. I think this is better.
I still need to add some test cases for missing keys and type errors but this logic should already be covered by the constraints.
So I have still have work on it. If you want to just wait until I am done, I can just continue working on it. But if you want to look at the approach feel free
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Just discussed #3461499-17: Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings → with @laurii, he agrees that all defaults should be specified in the SDC, not in a
Component
. See #3461499-19: Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings → and preceding comments.That means this is obsolete.
Automatically closed - issue fixed for 2 weeks with no activity.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
This is making a pretty drastic change that is not captured in the issue summary: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... — in that comment I explain why we should revert that and leave such a change for 🌱 [META] Support component types other than SDC Active to make.
I also found 2 critical gaps in the test coverage:
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
… and a number of additional questions.
- 🇺🇸United States phenaproxima Massachusetts
📌 Add validation constraints to language.content_settings.*.* Needs work landed!
- 🇬🇧United Kingdom longwave UK
Committed to 11.1.x and 10.4.x, this isn't a bug fix or critical task so not eligible for backport to 11.0.x or 10.3.x
Committed and pushed ac88e9a4d8 to 11.x and 6fc96204f7 to 10.4.x. Thanks!
-
longwave →
committed ac88e9a4 on 11.x
Issue #3458321 by narendraR, smustgrave, alexpott: Add validation...
-
longwave →
committed ac88e9a4 on 11.x
-
longwave →
committed 6fc96204 on 10.4.x
Issue #3458321 by narendraR, smustgrave, alexpott: Add validation...
-
longwave →
committed 6fc96204 on 10.4.x
- 🇮🇳India ganesh_paygude Pune
Changes in validation of short URL as per requirement.
- 🇮🇳India ganesh_paygude Pune
Changes in validation of short URL as per requirement.
- Issue created by @ganesh_paygude
- 🇺🇸United States phenaproxima Massachusetts
📌 Fix Block config entity type config schema violations: weight, property Postponed is in!
-
alexpott →
committed 1c218641 on 11.x
Issue #3379725 by Wim Leers, phenaproxima, narendraR, alexpott, quietone...
-
alexpott →
committed 1c218641 on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed 1c21864 and pushed to 11.x. Thanks!
Given where we are at in the 11.0.0 release cycle we can't commit this to 11.0.0 and have to target 11.1.0 instead. I've updated the deprecation messages and tests on commit.
diff --git a/core/modules/block/src/Entity/Block.php b/core/modules/block/src/Entity/Block.php index 2effc409b7..68582e48f0 100644 --- a/core/modules/block/src/Entity/Block.php +++ b/core/modules/block/src/Entity/Block.php @@ -349,7 +349,7 @@ public function preSave(EntityStorageInterface $storage) { parent::preSave($storage); if (!is_int($this->weight)) { - @trigger_error('Saving a block with a non-integer weight is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474', E_USER_DEPRECATED); + @trigger_error('Saving a block with a non-integer weight is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474', E_USER_DEPRECATED); $this->setWeight((int) $this->weight); } diff --git a/core/modules/block/tests/src/Kernel/BlockValidationTest.php b/core/modules/block/tests/src/Kernel/BlockValidationTest.php index 9a1a2412d6..2456e7fb57 100644 --- a/core/modules/block/tests/src/Kernel/BlockValidationTest.php +++ b/core/modules/block/tests/src/Kernel/BlockValidationTest.php @@ -176,7 +176,7 @@ public function testWeightValidation(): void { public function testWeightCannotBeNull(): void { $this->entity->set('weight', NULL); $this->assertNull($this->entity->getWeight()); - $this->expectDeprecation('Saving a block with a non-integer weight is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474'); + $this->expectDeprecation('Saving a block with a non-integer weight is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474'); $this->entity->save(); } diff --git a/core/modules/search/search.module b/core/modules/search/search.module index 8d5b1e330d..0944c53dcf 100644 --- a/core/modules/search/search.module +++ b/core/modules/search/search.module @@ -428,7 +428,7 @@ function search_block_presave(BlockInterface $block) { if ($block->getPluginId() === 'search_form_block') { $settings = $block->get('settings'); if ($settings['page_id'] === '') { - @trigger_error('Saving a search block with an empty page ID is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. To use the default search page, use NULL. See https://www.drupal.org/node/3463132', E_USER_DEPRECATED); + @trigger_error('Saving a search block with an empty page ID is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. To use the default search page, use NULL. See https://www.drupal.org/node/3463132', E_USER_DEPRECATED); $settings['page_id'] = NULL; $block->set('settings', $settings); }
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I reviewed it again today as well, and the one remark I had was answered. RTBC++
- 🇺🇸United States phenaproxima Massachusetts
Okay, I agree with you @tim.plunkett; did the deprecation dance around page_id and added a change record.