- First commit to issue fork.
- 🇬🇧United Kingdom thoward216
Coming back around to this, as per #10.
A new components config with one version looks like this:
uuid: d973b1d2-df01-4f89-a309-fe83f34c9d9a langcode: en status: true dependencies: config: - experience_builder.js_component.test active_version: 8fe3be948e0194e1 versioned_properties: active: settings: prop_field_definitions: { } fallback_metadata: slot_definitions: { } label: test id: js.test provider: null source: js source_local_id: test category: '@todo'
New versions created adds them under `versioned_properties` as expected but as you can see above the hash `8fe3be948e0194e1` is not in `versioned _properties`. So either the above isn't structured as expected (though I'm sure there are a number of tests around this) OR the original constraint that was commented to add later maybe stale?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'll review tomorrow — it's possible @larowlan will beat me to it, so not yet self-assigning.
- 🇬🇧United Kingdom f.mazeikis Brighton
I've addressed most of the feedback, replied with reasoning for the rest. This might not be complete, but a second pass review and further feedback on Comment on lines +802 to +804 would be beneficial.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
🏓 Responded to @f.mazeikis' most pressing question; didn't do a full review, but … the scope here is now no longer so narrow, but generic, thanks to ✨ Define JSON Schema $refs for linking/embedding videos and linking documents Active + ✨ Add a Video prop type to the Code Component editor Active .
- 🇭🇺Hungary Gábor Hojtsy Hungary
Sorry for the noise :D Was not very robust with select default for newly placed blocks. This will avoid an error when you newly place a webform component in XB.
-
jrockowitz →
committed 7ce0bb37 on 6.x authored by
phenaproxima →
Issue #3526637 by gábor hojtsy, mandclu, jrockowitz, penyaskito: Make...
-
jrockowitz →
committed 7ce0bb37 on 6.x authored by
phenaproxima →
- 🇭🇺Hungary Gábor Hojtsy Hungary
Also storing the select list patch here for those that need it to make webform work ASAP, although the bug around the autocomplete is in XB not in webform.
Automatically closed - issue fixed for 2 weeks with no activity.