- Issue created by @bbrala
- Merge request !11481Add NoEntitiesExistYetWithHigherCardinality valdator from parent issue → (Open) created by bbrala
- 🇳🇱Netherlands bbrala Netherlands
Added the changes from the parent, lets get some working tests.
- First commit to issue fork.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇱Netherlands bbrala Netherlands
I did a bugfix for the validator in the parent issue: https://git.drupalcode.org/project/drupal/-/merge_requests/3047/diffs?co...
That change is needed here also.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I have some small documentation remarks, but this looks great.
- 🇳🇱Netherlands bbrala Netherlands
Yeah cr, is, and title updtae. Since this basically is the implementation of this constraint.
- 🇳🇱Netherlands bbrala Netherlands
Title updated.
I looked at other issues regarding validation, and when there is no change in the interface (like '' becoming NULL) it seems it is not needed to have a CR as far as i can see.
- 🇺🇸United States smustgrave
Right but maybe we should.
Just to announce the new validation type that contrib modules can now use.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I reviewed the CR. It has all the information needed.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.