- 🇬🇧United Kingdom alexpott 🇪🇺🌍
We need to update the deprecations to 11.3.x plus I think the hook this MR adds does not have the correct info the annotation.
-
wim leers →
committed 8ade7ebe on 0.x authored by
meghasharma →
Issue #3525759 by wim leers, meghasharma, larowlan:...
-
wim leers →
committed 8ade7ebe on 0.x authored by
meghasharma →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
🤔 I think it can still be wrong.
Because
\Drupal\experience_builder\ComponentSource\ComponentSourceBase::generateVersionHash()
looks at$normalized_data = [ 'settings' => $typed_source_specific_settings->toArray(), 'slot_definitions' => $this instanceof ComponentSourceWithSlotsInterface ? self::normalizeSlotDefinitions($this->getSlotDefinitions()) : [], 'schema' => $this->getExplicitInputDefinitions(), ];
There's nothing preventing
$typed_source_specific_settings
to contain too much data — that'd just end up being hashed along with it; still resulting in a predictable version … just one based on mismatched settings.In fact,
\Drupal\Tests\experience_builder\Kernel\Config\ComponentValidationTest::setUp()
proves that this is still the case. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I think is probably moot post 🐛 Deterministic Component version hash should depend not only on source-specific settings, but also slots + explicit input schema Active as the validation won't pass because the version doesn't match?
-
wim leers →
committed 7c299d95 on 0.x authored by
larowlan →
Issue #3526127 by larowlan, wim leers: Ensure deterministic config...
-
wim leers →
committed 7c299d95 on 0.x authored by
larowlan →
-
wim leers →
committed 1911c983 on 0.x authored by
larowlan →
Issue #3528362 by larowlan, wim leers: Deterministic Component version...
-
wim leers →
committed 1911c983 on 0.x authored by
larowlan →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Updated
/admin/appearance/component
to show the number of versions of each component, and shows the active version upon hover. - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks, @larowlan, for pushing this to completion! All I had to do here was fix nits, and add docs for the tricky bits 😊
Issue summary updated.
- First commit to issue fork.
- @larowlan opened merge request.