-
rajab natshah โ
committed e09bb599 on 2.0.x authored by
mortona2k โ
Issue #2941227: Fix missing install/schema to support configs with...
-
rajab natshah โ
committed e09bb599 on 2.0.x authored by
mortona2k โ
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Faced issues with Recipes and
simpleConfigUpdate
action.
๐ Fix Varbase Editor Default Recipe to Import/Update Configs and Follow Schema with Configuration Inspector Fixeddoing something like the following in a recipe will not work
config: actions: ace_editor.settings: simpleConfigUpdate: theme: idle_fingers syntax: html height: auto width: '700px' font_size: '9pt' show_invisibles: false
- ๐ฌ๐งUnited Kingdom longwave UK
I don't get why we need to do this. DX is slightly nicer if developers can pass a string in the simple case or an array of strings otherwise. Given it's been over 10 years since this was proposed are there better things to work on?
- ๐ณ๐ฟNew Zealand quietone New Zealand
Rebased and updated the deprecation notice.
- First commit to issue fork.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks. I tested and found the following:
1. Shoe button is missing... not sure why and didn't debug but maybe due to the variant info?
2. Shoe badge and shoe tab are "working" (other than the boolean true/false issue that I reported).
๐ [PP-1] Can't toggle boolean prop back to true after changing to false Postponed
3. Some others cause fatal errors...
shoe icon and shoe tab panel have known issue:
Drupal\Core\Render\Component\Exception\InvalidComponentException: [name] The property name is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 206 of /var/www/html/web/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
๐ Some components cannot be used in XB because UI prevents SDC props being named `name` Active
4. Sidenote that there are a lot of these:
Attempting to re-run cron while it is already running.
as well for some reason.
- ๐ณ๐ฟNew Zealand quietone New Zealand
I am closing this support request because there have been no recent comments.
The Drupal Core issue queue is not the ideal place for support requests. The 'support request' option is there for filing support issues for contributed modules and themes. There are several support options listed on our support page โ (Community > Support at the top of Drupal.org) and there is Drupal Slack โ . You may get better replies in one of those places.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Oops โฆ ๐
I got this wrong, because I got #3469609 wrong โ see #3469609-18: Prepare for multiple component types: ComponentTreeStructure should contain Component config entity IDs, not SDC IDs โ .
Fixed now.
@ankitv18 Thanks!
@quietone I added a new change record (draft state).
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Next up: ๐ Surface the REASON for an SDC not being made available in XB (i.e. not meeting criteria) Active ๐ฅณ
-
wim leers โ
committed 25d5779c on 0.x
Issue #3470550 by wim leers, f.mazeikis, kristen pol: Component config...
-
wim leers โ
committed 25d5779c on 0.x
- ๐ฎ๐ณIndia ankitv18
I've confirmed your user profil, now you can see the CR shared via @quietone ~~ I guess you need to add only this issue url over there.
@quietone please confirm on the same? @quietone how can I add a change record?
I can not see the link "add change notice" in the issue sidebar.
Thanks
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Yes, for all XB components. With the exception of the special
all-props
SDC, which we're using to be able to test/develop missing pieces. But that's not an SDC that is installed by default. - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
So if both this and that issue are fixed then there will no more fatal errors when using the prop forms for ALL XB example components? If so, ETA on both?
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
The boolean shenanigans reported in #23 are indeed unrelated.
The goal of this issue is to be able to render the
ComponentPropsForm
without triggering the PHP warnings reported in #3. That it does ๐If I interact with the boolean field widget, I can also reproduce
Drupal\Core\Render\Component\Exception\InvalidComponentException: [pill] String value found, but a boolean or an object is required/n[pulse] Integer value found, but a boolean or an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
This is being worked on in ๐ Component props form: map textarea, bool, and select elements to React components Fixed . The root cause is the request to update the preview after interacting with the boolean field widget, which sends this data from the client to the server that indeed violates the JSON schema, because both
pill
andpulse
must be booleans, not strings nor integers: - ๐ซ๐ฎFinland lauriii Finland
It seems that #23 might be related to ๐ `enum` data shapes: error when choosing "- None -" in `` Needs work but maybe there's an aspect related to booleans that isn't being tracked there currently?
- ๐ซ๐ฎFinland lauriii Finland
I added the shoe icon component and got the following error:
Drupal\Core\Render\Component\Exception\InvalidComponentException: [name] The property name is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of /var/www/html/drupal/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
I changed a value for the shoe tab component using the right sidebar and got the following error:
Drupal\Core\Render\Component\Exception\InvalidComponentException: [active] Integer value found, but a boolean or an object is required/n[closable] Integer value found, but a boolean or an object is required/n[disabled] Integer value found, but a boolean or an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of /var/www/html/drupal/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
I changed a value for the shoe badge using the right sidebar and got the following error:
Drupal\Core\Render\Component\Exception\InvalidComponentException: [pill] Integer value found, but a boolean or an object is required/n[pulse] Integer value found, but a boolean or an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of /var/www/html/drupal/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
I changed a value for the shoe tab group using the right sidebar and got the following error:
Drupal\Core\Render\Component\Exception\InvalidComponentException: [no_scroll] Integer value found, but a boolean or an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of /var/www/html/drupal/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
I'll let @wim leers and/or @f.mazeikis to decide if this is something that should be fixed here or in a follow-up issue.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
The shoe components are still causing errors.
Try dragging shoe icon or shoe tab panel and you'll see the error popup.
Or drag shoe badge, shoe tab, or shoe tab group and try changing something.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
For testing, I needed to get the fix from this issue in there:
๐ Prop select lists don't affect the component Fixed
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Forgot to re-assign to Felix :)
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Closed ๐ Component config entity should validate that the SDC actually (still) exists Active as outdated โ @f.mazeikis implemented that as part of this issue.
This is ready for final sign-off by @f.mazeikis. We both worked on this, but he's the owner of ๐๐
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
https://git.drupalcode.org/project/experience_builder/-/merge_requests/2... solved this as part of ๐ Component config entity should validate that the SDC actually (still) exists Active .
- ๐ช๐ธSpain iiRealXz
After implementing this change, when installing a fresh install in a language other than English and using the โstandardโ installation profile, for exampleโ, I get the following error:
the configuration objects have different language codes so they cannot be translated