- 🇺🇸United States smustgrave
My mistake.
rest of the change appears good to me then
- 🇺🇸United States smustgrave
Left 1 comment on MR
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- 🇦🇺Australia acbramley
That's a top level setting on the block itself. These settings that we are removing do absolutely nothing.
- 🇺🇸United States smustgrave
If we remove the status field won’t that preventing unpublishing of a block now
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I looked at the entire MR again, since it came up in one of Wim's XB weeks: https://wimleers.com/xb-week-24
I think the merge request looks great, and I don't have any big open questions, it needs a rebase and Wim needs to close some of the open questions (that's still only possible to do for the mr author).We also need to find an answer to the question highlighted in #282.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Since this was added to the IS, there was a complete rewrite of the patch, is it still valid? Do we have to postpone this on that?
Needs further investigation: #2905594: Missing entity validation constraint: don't allow new entities when there is an existing one with the same ID by @dawehner in #181. This might be a bit of missing test coverage?
